Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2499053003: Simplify RenderFrameImpl::ResolveOpener() (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 RenderViewImpl* render_view; 219 RenderViewImpl* render_view;
220 int32_t routing_id; 220 int32_t routing_id;
221 }; 221 };
222 222
223 using CreateRenderFrameImplFunction = 223 using CreateRenderFrameImplFunction =
224 RenderFrameImpl* (*)(const CreateParams&); 224 RenderFrameImpl* (*)(const CreateParams&);
225 static void InstallCreateHook( 225 static void InstallCreateHook(
226 CreateRenderFrameImplFunction create_render_frame_impl); 226 CreateRenderFrameImplFunction create_render_frame_impl);
227 227
228 // Looks up and returns the WebFrame corresponding to a given opener frame 228 // Looks up and returns the WebFrame corresponding to a given opener frame
229 // routing ID. Also stores the opener's RenderView routing ID into 229 // routing ID.
230 // |opener_view_routing_id|. 230 static blink::WebFrame* ResolveOpener(int opener_frame_routing_id);
231 //
232 // TODO(alexmos): remove RenderViewImpl's dependency on
233 // opener_view_routing_id.
234 static blink::WebFrame* ResolveOpener(int opener_frame_routing_id,
235 int* opener_view_routing_id);
236 231
237 // Overwrites the given URL to use an HTML5 embed if possible. 232 // Overwrites the given URL to use an HTML5 embed if possible.
238 blink::WebURL overrideFlashEmbedWithHTML(const blink::WebURL& url) override; 233 blink::WebURL overrideFlashEmbedWithHTML(const blink::WebURL& url) override;
239 234
240 ~RenderFrameImpl() override; 235 ~RenderFrameImpl() override;
241 236
242 // Called by RenderWidget when meaningful layout has happened. 237 // Called by RenderWidget when meaningful layout has happened.
243 // See RenderFrameObserver::DidMeaningfulLayout declaration for details. 238 // See RenderFrameObserver::DidMeaningfulLayout declaration for details.
244 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type); 239 void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type);
245 240
(...skipping 1093 matching lines...) Expand 10 before | Expand all | Expand 10 after
1339 bool browser_side_navigation_pending_ = false; 1334 bool browser_side_navigation_pending_ = false;
1340 1335
1341 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1336 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1342 1337
1343 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1338 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1344 }; 1339 };
1345 1340
1346 } // namespace content 1341 } // namespace content
1347 1342
1348 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1343 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698