Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2494923002: Hook up with ANGLE translator's remove_invariant_and_centroid option. (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up with ANGLE translator's remove_invariant_and_centroid option. BUG=641129, 639760 TEST=webgl2_conformance R=kbr@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/f7897214efb453c76bd3c896e1cf42bcdf55ca5e Cr-Commit-Position: refs/heads/master@{#431472}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Total comments: 2

Patch Set 4 : message fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 chunks +7 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 3 2 chunks +28 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
Ken Russell (switch to Gerrit)
Excellent; LGTM with one tiny comment. https://codereview.chromium.org/2494923002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2494923002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc#newcode2188 gpu/config/gpu_driver_bug_list_json.cc:2188: "description": "Mac driver ...
4 years, 1 month ago (2016-11-11 02:01:12 UTC) #7
Zhenyao Mo
https://codereview.chromium.org/2494923002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2494923002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc#newcode2188 gpu/config/gpu_driver_bug_list_json.cc:2188: "description": "Mac driver GL 4.1 requires invariant and centroid ...
4 years, 1 month ago (2016-11-11 02:32:04 UTC) #8
Zhenyao Mo
On 2016/11/11 02:32:04, Zhenyao Mo wrote: > https://codereview.chromium.org/2494923002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc > File gpu/config/gpu_driver_bug_list_json.cc (right): > > https://codereview.chromium.org/2494923002/diff/40001/gpu/config/gpu_driver_bug_list_json.cc#newcode2188 ...
4 years, 1 month ago (2016-11-11 02:32:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494923002/60001
4 years, 1 month ago (2016-11-11 02:33:22 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-11 02:39:35 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 02:46:26 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f7897214efb453c76bd3c896e1cf42bcdf55ca5e
Cr-Commit-Position: refs/heads/master@{#431472}

Powered by Google App Engine
This is Rietveld 408576698