Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2494683005: Fix bug where DeterministicDispatcher CHECKed for killed jobs (Closed)

Created:
4 years, 1 month ago by alex clarke (OOO till 29th)
Modified:
4 years, 1 month ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug where DeterministicDispatcher CHECKed for killed jobs BUG=546953 Committed: https://crrev.com/6a8aa2f9af202c27f8d8eab9783f42595fed6513 Cr-Commit-Position: refs/heads/master@{#431550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M headless/public/util/deterministic_dispatcher.h View 2 chunks +3 lines, -0 lines 0 comments Download
M headless/public/util/deterministic_dispatcher.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M headless/public/util/deterministic_dispatcher_test.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M headless/public/util/testing/fake_managed_dispatch_url_request_job.h View 1 chunk +2 lines, -0 lines 0 comments Download
M headless/public/util/testing/fake_managed_dispatch_url_request_job.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
alex clarke (OOO till 29th)
PTAL
4 years, 1 month ago (2016-11-11 12:21:20 UTC) #2
Sami
lgtm, thanks for the fix!
4 years, 1 month ago (2016-11-11 12:23:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494683005/1
4 years, 1 month ago (2016-11-11 12:26:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 12:48:09 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 12:50:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a8aa2f9af202c27f8d8eab9783f42595fed6513
Cr-Commit-Position: refs/heads/master@{#431550}

Powered by Google App Engine
This is Rietveld 408576698