Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: headless/public/util/testing/fake_managed_dispatch_url_request_job.h

Issue 2494683005: Fix bug where DeterministicDispatcher CHECKed for killed jobs (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef HEADLESS_PUBLIC_UTIL_TESTING_FAKE_MANAGED_DISPATCH_URL_REQUEST_JOB_H_ 5 #ifndef HEADLESS_PUBLIC_UTIL_TESTING_FAKE_MANAGED_DISPATCH_URL_REQUEST_JOB_H_
6 #define HEADLESS_PUBLIC_UTIL_TESTING_FAKE_MANAGED_DISPATCH_URL_REQUEST_JOB_H_ 6 #define HEADLESS_PUBLIC_UTIL_TESTING_FAKE_MANAGED_DISPATCH_URL_REQUEST_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 13 matching lines...) Expand all
24 std::vector<std::string>* notifications) 24 std::vector<std::string>* notifications)
25 : ManagedDispatchURLRequestJob(nullptr, nullptr, url_request_dispatcher), 25 : ManagedDispatchURLRequestJob(nullptr, nullptr, url_request_dispatcher),
26 id_(id), 26 id_(id),
27 notifications_(notifications) {} 27 notifications_(notifications) {}
28 28
29 ~FakeManagedDispatchURLRequestJob() override {} 29 ~FakeManagedDispatchURLRequestJob() override {}
30 30
31 using ManagedDispatchURLRequestJob::DispatchHeadersComplete; 31 using ManagedDispatchURLRequestJob::DispatchHeadersComplete;
32 using ManagedDispatchURLRequestJob::DispatchStartError; 32 using ManagedDispatchURLRequestJob::DispatchStartError;
33 33
34 void Kill() override;
35
34 void Start() override {} 36 void Start() override {}
35 37
36 void OnHeadersComplete() override; 38 void OnHeadersComplete() override;
37 39
38 void OnStartError(net::Error error) override; 40 void OnStartError(net::Error error) override;
39 41
40 private: 42 private:
41 int id_; 43 int id_;
42 std::vector<std::string>* notifications_; // NOT OWNED 44 std::vector<std::string>* notifications_; // NOT OWNED
43 45
44 DISALLOW_COPY_AND_ASSIGN(FakeManagedDispatchURLRequestJob); 46 DISALLOW_COPY_AND_ASSIGN(FakeManagedDispatchURLRequestJob);
45 }; 47 };
46 48
47 } // namespace headless 49 } // namespace headless
48 50
49 #endif // HEADLESS_PUBLIC_UTIL_TESTING_FAKE_MANAGED_DISPATCH_URL_REQUEST_JOB_H_ 51 #endif // HEADLESS_PUBLIC_UTIL_TESTING_FAKE_MANAGED_DISPATCH_URL_REQUEST_JOB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698