headless/public/util/testing/fake_managed_dispatch_url_request_job.h - Issue 2494683005: Fix bug where DeterministicDispatcher CHECKed for killed jobs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/public/util/testing/fake_managed_dispatch_url_request_job.h

Issue 2494683005: Fix bug where DeterministicDispatcher CHECKed for killed jobs (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « headless/public/util/deterministic_dispatcher_test.cc ('k') | headless/public/util/testing/fake_managed_dispatch_url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/public/util/testing/fake_managed_dispatch_url_request_job.h

diff --git a/headless/public/util/testing/fake_managed_dispatch_url_request_job.h b/headless/public/util/testing/fake_managed_dispatch_url_request_job.h

index cb0dabdf5b1212ecdd79883dc6c59afae4fc3558..79a749bd2613641831f0f3cad97d86eb1fcd66b2 100644

--- a/headless/public/util/testing/fake_managed_dispatch_url_request_job.h

+++ b/headless/public/util/testing/fake_managed_dispatch_url_request_job.h

@@ -31,6 +31,8 @@ class FakeManagedDispatchURLRequestJob : public ManagedDispatchURLRequestJob {

using ManagedDispatchURLRequestJob::DispatchHeadersComplete;

using ManagedDispatchURLRequestJob::DispatchStartError;

+ void Kill() override;

void Start() override {}

void OnHeadersComplete() override;