Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2981)

Unified Diff: headless/public/util/deterministic_dispatcher_test.cc

Issue 2494683005: Fix bug where DeterministicDispatcher CHECKed for killed jobs (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/util/deterministic_dispatcher_test.cc
diff --git a/headless/public/util/deterministic_dispatcher_test.cc b/headless/public/util/deterministic_dispatcher_test.cc
index b4c1c1fe08928e25d40d664fe88107973863355a..24cede8b2e9a9df3bf368a6d6e03513c4ef4139a 100644
--- a/headless/public/util/deterministic_dispatcher_test.cc
+++ b/headless/public/util/deterministic_dispatcher_test.cc
@@ -110,4 +110,20 @@ TEST_F(DeterministicDispatcherTest,
"id: 3 err: -123", "id: 4 OK"));
}
+TEST_F(DeterministicDispatcherTest, JobKilled) {
+ std::vector<std::string> notifications;
+ {
+ std::unique_ptr<FakeManagedDispatchURLRequestJob> job(
+ new FakeManagedDispatchURLRequestJob(deterministic_dispatcher_.get(), 1,
+ &notifications));
+
+ job->Kill();
+ }
+
+ EXPECT_TRUE(notifications.empty());
+
+ base::RunLoop().RunUntilIdle();
+ EXPECT_TRUE(notifications.empty());
+}
+
} // namespace headless
« no previous file with comments | « headless/public/util/deterministic_dispatcher.cc ('k') | headless/public/util/testing/fake_managed_dispatch_url_request_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698