Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2493853002: cc/blimp: Proto Cleanup. (Closed)

Created:
4 years, 1 month ago by Khushal
Modified:
4 years, 1 month ago
Reviewers:
ajuma, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org, Kevin M
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc/blimp: Proto Cleanup. Remove all unused protos and serialization code. BUG=648442 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7 Cr-Commit-Position: refs/heads/master@{#431782}

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2898 lines) Patch
M cc/BUILD.gn View 1 2 3 7 chunks +0 lines, -12 lines 0 comments Download
M cc/animation/element_id.h View 1 2 3 4 2 chunks +0 lines, -11 lines 0 comments Download
M cc/animation/element_id.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M cc/blimp/compositor_state_deserializer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/debug/layer_tree_debug_state.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/debug/layer_tree_debug_state.cc View 2 chunks +0 lines, -39 lines 0 comments Download
D cc/debug/layer_tree_debug_state_unittest.cc View 1 1 chunk +0 lines, -62 lines 0 comments Download
M cc/layers/heads_up_display_layer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/heads_up_display_layer.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/output/begin_frame_args.h View 3 chunks +0 lines, -9 lines 0 comments Download
M cc/output/begin_frame_args.cc View 3 chunks +0 lines, -55 lines 0 comments Download
M cc/output/begin_frame_args_unittest.cc View 1 2 chunks +0 lines, -32 lines 0 comments Download
M cc/output/managed_memory_policy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/managed_memory_policy.cc View 2 chunks +0 lines, -17 lines 0 comments Download
D cc/output/managed_memory_policy_unittest.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
M cc/output/renderer_settings.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/output/renderer_settings.cc View 2 chunks +0 lines, -56 lines 0 comments Download
D cc/output/renderer_settings_unittest.cc View 1 1 chunk +0 lines, -78 lines 0 comments Download
M cc/playback/recording_source.h View 2 chunks +0 lines, -9 lines 0 comments Download
M cc/playback/recording_source.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M cc/playback/recording_source_unittest.cc View 1 2 chunks +0 lines, -60 lines 0 comments Download
M cc/proto/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D cc/proto/begin_main_frame_and_commit_state.proto View 1 chunk +0 lines, -56 lines 0 comments Download
M cc/proto/cc_conversions.h View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/proto/cc_conversions.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D cc/proto/commit_earlyout_reason.proto View 1 chunk +0 lines, -20 lines 0 comments Download
M cc/proto/compositor_message.proto View 2 chunks +0 lines, -6 lines 0 comments Download
D cc/proto/compositor_message_to_impl.proto View 1 chunk +0 lines, -106 lines 0 comments Download
D cc/proto/compositor_message_to_main.proto View 1 chunk +0 lines, -39 lines 0 comments Download
D cc/proto/element_id.proto View 1 chunk +0 lines, -18 lines 0 comments Download
D cc/proto/gpu_conversions.h View 1 chunk +0 lines, -25 lines 0 comments Download
D cc/proto/gpu_conversions.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D cc/proto/gpu_conversions_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M cc/proto/layer.proto View 4 chunks +3 lines, -39 lines 0 comments Download
M cc/proto/layer_tree.proto View 2 chunks +0 lines, -13 lines 0 comments Download
D cc/proto/layer_tree_debug_state.proto View 1 chunk +0 lines, -30 lines 0 comments Download
M cc/proto/layer_tree_host.proto View 2 chunks +0 lines, -12 lines 0 comments Download
D cc/proto/managed_memory_policy.proto View 1 chunk +0 lines, -17 lines 0 comments Download
D cc/proto/memory_allocation.proto View 1 chunk +0 lines, -19 lines 0 comments Download
D cc/proto/property_tree.proto View 1 chunk +0 lines, -239 lines 0 comments Download
D cc/proto/recording_source.proto View 1 chunk +0 lines, -23 lines 0 comments Download
M cc/proto/region.proto View 1 chunk +1 line, -1 line 0 comments Download
D cc/proto/renderer_settings.proto View 1 chunk +0 lines, -32 lines 0 comments Download
D cc/proto/synced_property.proto View 1 chunk +0 lines, -29 lines 0 comments Download
D cc/proto/synced_property_conversions.h View 1 chunk +0 lines, -26 lines 0 comments Download
D cc/proto/synced_property_conversions.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D cc/proto/synced_property_conversions_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M cc/scheduler/commit_earlyout_reason.h View 2 chunks +0 lines, -12 lines 0 comments Download
D cc/scheduler/commit_earlyout_reason.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D cc/scheduler/commit_earlyout_reason_unittest.cc View 1 1 chunk +0 lines, -39 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/clip_node.h View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/clip_node.cc View 2 chunks +0 lines, -54 lines 0 comments Download
M cc/trees/effect_node.h View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/effect_node.cc View 2 chunks +0 lines, -64 lines 0 comments Download
M cc/trees/layer_tree_host_common.h View 4 chunks +0 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 4 chunks +0 lines, -53 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 chunks +0 lines, -39 lines 0 comments Download
M cc/trees/property_tree.h View 9 chunks +0 lines, -40 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 8 chunks +0 lines, -244 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 1 28 chunks +33 lines, -508 lines 0 comments Download
M cc/trees/proxy_common.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/proxy_common.cc View 2 chunks +0 lines, -20 lines 0 comments Download
D cc/trees/proxy_common_unittest.cc View 1 1 chunk +0 lines, -58 lines 0 comments Download
M cc/trees/scroll_node.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/scroll_node.cc View 2 chunks +0 lines, -55 lines 0 comments Download
M cc/trees/transform_node.h View 3 chunks +0 lines, -11 lines 0 comments Download
M cc/trees/transform_node.cc View 3 chunks +0 lines, -134 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Khushal
And final cleanup patch. Updating the tests on this too.
4 years, 1 month ago (2016-11-10 19:50:29 UTC) #3
Khushal
+enne on this one. Since it looks like ajuma@ is OOO.
4 years, 1 month ago (2016-11-11 00:35:46 UTC) #9
enne (OOO)
Yeah, lgtm. I was a little bit surprised to see property tree proto code go ...
4 years, 1 month ago (2016-11-11 19:24:55 UTC) #11
Khushal
On 2016/11/11 19:24:55, enne wrote: > Yeah, lgtm. I was a little bit surprised to ...
4 years, 1 month ago (2016-11-11 19:52:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493853002/80001
4 years, 1 month ago (2016-11-12 08:11:32 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-12 09:22:20 UTC) #17
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/4762e7cc7d6ff39382c0fa9266d1db0ab0467bf7 Cr-Commit-Position: refs/heads/master@{#431782}
4 years, 1 month ago (2016-11-12 09:24:41 UTC) #19
agrieve
On 2016/11/12 09:24:41, commit-bot: I haz the power wrote: > Patchset 5 (id:??) landed as ...
4 years, 1 month ago (2016-11-16 15:57:21 UTC) #20
Khushal
4 years, 1 month ago (2016-11-16 23:57:12 UTC) #21
Message was sent while issue was closed.
That's awesome! :D
+Kevin who is also working on restricting proto usage in the blimp layer to
minimize the overhead we add to the apk size.

Powered by Google App Engine
This is Rietveld 408576698