Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2493173002: [turbofan] Fix more -Wsign-compare warnings. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix more -Wsign-compare warnings. BUG=v8:5614 Committed: https://crrev.com/758b317ce531b959b8cb7466f2d1b8eefa05845c Cr-Commit-Position: refs/heads/master@{#40916}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -67 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/arm/unwinding-info-writer-arm.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/arm64/unwinding-info-writer-arm64.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/x64/unwinding-info-writer-x64.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/eh-frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-load-store.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-wasm-machops.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 2 chunks +13 lines, -15 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/eh-frame-iterator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/eh-frame-writer-unittest.cc View 9 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
ulan
ptal, after this turbofan compiles without warnings both in release and debug modes.
4 years, 1 month ago (2016-11-11 10:39:22 UTC) #3
Benedikt Meurer
LGTM (rubber-stamped)
4 years, 1 month ago (2016-11-11 10:43:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493173002/1
4 years, 1 month ago (2016-11-11 10:46:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/11991) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-11 10:48:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493173002/20001
4 years, 1 month ago (2016-11-11 11:32:50 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/12225)
4 years, 1 month ago (2016-11-11 11:34:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493173002/20001
4 years, 1 month ago (2016-11-11 11:39:43 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 12:00:40 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:20 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/758b317ce531b959b8cb7466f2d1b8eefa05845c
Cr-Commit-Position: refs/heads/master@{#40916}

Powered by Google App Engine
This is Rietveld 408576698