[turbofan] Fix more -Wsign-compare warnings.

test/unittests/eh-frame-writer-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/eh-frame.h"
 #include "test/unittests/test-utils.h"
 
 // Test enabled only on supported architectures.
 #if defined(V8_TARGET_ARCH_X64) || defined(V8_TARGET_ARCH_ARM) || \
     defined(V8_TARGET_ARCH_ARM64)
@@ skipping 57 matching lines @@
   int procedure_address_offset = iterator.GetCurrentOffset();
   int procedure_address = iterator.GetNextUInt32();
   EXPECT_EQ(-(procedure_address_offset + RoundUp(kProcedureSize, 8)),
             procedure_address);
 
   int procedure_size = iterator.GetNextUInt32();
   EXPECT_EQ(kProcedureSize, procedure_size);
 }
 
 TEST_F(EhFrameWriterTest, SetOffset) {
-  static const int kOffset = 0x0badc0de;
+  static const uint32_t kOffset = 0x0badc0de;
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.SetBaseAddressOffset(kOffset);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
 
   EXPECT_EQ(EhFrameConstants::DwarfOpcodes::kDefCfaOffset,
             iterator.GetNextOpcode());
   EXPECT_EQ(kOffset, iterator.GetNextULeb128());
 }
 
 TEST_F(EhFrameWriterTest, IncreaseOffset) {
-  static const int kFirstOffset = 121;
-  static const int kSecondOffset = 16;
+  static const uint32_t kFirstOffset = 121;
+  static const uint32_t kSecondOffset = 16;
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.SetBaseAddressOffset(kFirstOffset);
   writer.IncreaseBaseAddressOffset(kSecondOffset);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
 
@@ skipping 12 matching lines @@
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.SetBaseAddressRegister(test_register);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
 
   EXPECT_EQ(EhFrameConstants::DwarfOpcodes::kDefCfaRegister,
             iterator.GetNextOpcode());
-  EXPECT_EQ(kTestRegisterCode, iterator.GetNextULeb128());
+  EXPECT_EQ(static_cast<uint32_t>(kTestRegisterCode),
+            iterator.GetNextULeb128());
 }
 
 TEST_F(EhFrameWriterTest, SetRegisterAndOffset) {
   Register test_register = Register::from_code(kTestRegisterCode);
-  static const int kOffset = 0x0badc0de;
+  static const uint32_t kOffset = 0x0badc0de;
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.SetBaseAddressRegisterAndOffset(test_register, kOffset);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
 
   EXPECT_EQ(EhFrameConstants::DwarfOpcodes::kDefCfa, iterator.GetNextOpcode());
-  EXPECT_EQ(kTestRegisterCode, iterator.GetNextULeb128());
+  EXPECT_EQ(static_cast<uint32_t>(kTestRegisterCode),
+            iterator.GetNextULeb128());
   EXPECT_EQ(kOffset, iterator.GetNextULeb128());
 }
 
 TEST_F(EhFrameWriterTest, PcOffsetEncoding6bit) {
   static const int kOffset = 42;
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.AdvanceLocation(kOffset * EhFrameConstants::kCodeAlignmentFactor);
   writer.Finish(100);
@@ skipping 99 matching lines @@
   EXPECT_EQ(EhFrameConstants::DwarfOpcodes::kAdvanceLoc1,
             iterator.GetNextOpcode());
   EXPECT_EQ(kFirstOffset, iterator.GetNextByte());
 
   EXPECT_EQ(EhFrameConstants::DwarfOpcodes::kAdvanceLoc2,
             iterator.GetNextOpcode());
   EXPECT_EQ(kSecondOffset - kFirstOffset, iterator.GetNextUInt16());
 }
 
 TEST_F(EhFrameWriterTest, PcOffsetEncoding32bit) {
-  static const int kOffset = kMaxUInt16 + 42;
+  static const uint32_t kOffset = kMaxUInt16 + 42;
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.AdvanceLocation(kOffset * EhFrameConstants::kCodeAlignmentFactor);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
 
   EXPECT_EQ(EhFrameConstants::DwarfOpcodes::kAdvanceLoc4,
             iterator.GetNextOpcode());
   EXPECT_EQ(kOffset, iterator.GetNextUInt32());
 }
 
 TEST_F(EhFrameWriterTest, PcOffsetEncoding32bitDelta) {
-  static const int kFirstOffset = kMaxUInt16 + 0x42;
-  static const int kSecondOffset = kMaxUInt16 + 0x67;
+  static const uint32_t kFirstOffset = kMaxUInt16 + 0x42;
+  static const uint32_t kSecondOffset = kMaxUInt16 + 0x67;
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.AdvanceLocation(kFirstOffset * EhFrameConstants::kCodeAlignmentFactor);
   writer.AdvanceLocation(kSecondOffset *
                          EhFrameConstants::kCodeAlignmentFactor);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
@@ skipping 12 matching lines @@
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.RecordRegisterSavedToStack(test_register, kOffset);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
 
   EXPECT_EQ((2 << 6) | kTestRegisterCode, iterator.GetNextByte());
-  EXPECT_EQ(kOffset / EhFrameConstants::kDataAlignmentFactor,
-            iterator.GetNextULeb128());
+  EXPECT_EQ(
+      static_cast<uint32_t>(kOffset / EhFrameConstants::kDataAlignmentFactor),
+      iterator.GetNextULeb128());
 }
 
 TEST_F(EhFrameWriterTest, SaveRegisterSignedOffset) {
   Register test_register = Register::from_code(kTestRegisterCode);
   static const int kOffset =
       EhFrameConstants::kDataAlignmentFactor < 0 ? 12344 : -12344;
 
   ASSERT_EQ(kOffset % EhFrameConstants::kDataAlignmentFactor, 0);
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.RecordRegisterSavedToStack(test_register, kOffset);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
 
   EXPECT_EQ(EhFrameConstants::DwarfOpcodes::kOffsetExtendedSf,
             iterator.GetNextOpcode());
-  EXPECT_EQ(kTestRegisterCode, iterator.GetNextULeb128());
+  EXPECT_EQ(static_cast<uint32_t>(kTestRegisterCode),
+            iterator.GetNextULeb128());
   EXPECT_EQ(kOffset / EhFrameConstants::kDataAlignmentFactor,
             iterator.GetNextSLeb128());
 }
 
 TEST_F(EhFrameWriterTest, RegisterNotModified) {
   Register test_register = Register::from_code(kTestRegisterCode);
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.RecordRegisterNotModified(test_register);
   writer.Finish(100);
 
   EhFrameIterator iterator = MakeIterator(&writer);
   iterator.SkipToFdeDirectives();
 
   EXPECT_EQ(EhFrameConstants::DwarfOpcodes::kSameValue,
             iterator.GetNextOpcode());
-  EXPECT_EQ(kTestRegisterCode, iterator.GetNextULeb128());
+  EXPECT_EQ(static_cast<uint32_t>(kTestRegisterCode),
+            iterator.GetNextULeb128());
 }
 
 TEST_F(EhFrameWriterTest, RegisterFollowsInitialRule) {
   Register test_register = Register::from_code(kTestRegisterCode);
 
   EhFrameWriter writer(zone());
   writer.Initialize();
   writer.RecordRegisterFollowsInitialRule(test_register);
   writer.Finish(100);
 
@@ skipping 91 matching lines @@
   int offset_to_procedure = iterator.GetNextUInt32();
   EXPECT_EQ(-(eh_frame_size + kPaddingSize + kCodeSize), offset_to_procedure);
 
   // B -> C
   int offset_to_fde = iterator.GetNextUInt32();
   EXPECT_EQ(-(fde_size + EhFrameConstants::kEhFrameTerminatorSize),
             offset_to_fde);
 }
 
 #endif