Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Side by Side Diff: src/arm/assembler-arm.h

Issue 2493173002: [turbofan] Fix more -Wsign-compare warnings. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm/assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 1567 matching lines...) Expand 10 before | Expand all | Expand 10 after
1578 // Resume constant pool emission. Need to be called as many time as 1578 // Resume constant pool emission. Need to be called as many time as
1579 // StartBlockConstPool to have an effect. 1579 // StartBlockConstPool to have an effect.
1580 void EndBlockConstPool() { 1580 void EndBlockConstPool() {
1581 if (--const_pool_blocked_nesting_ == 0) { 1581 if (--const_pool_blocked_nesting_ == 0) {
1582 #ifdef DEBUG 1582 #ifdef DEBUG
1583 // Max pool start (if we need a jump and an alignment). 1583 // Max pool start (if we need a jump and an alignment).
1584 int start = pc_offset() + kInstrSize + 2 * kPointerSize; 1584 int start = pc_offset() + kInstrSize + 2 * kPointerSize;
1585 // Check the constant pool hasn't been blocked for too long. 1585 // Check the constant pool hasn't been blocked for too long.
1586 DCHECK(pending_32_bit_constants_.empty() || 1586 DCHECK(pending_32_bit_constants_.empty() ||
1587 (start + pending_64_bit_constants_.size() * kDoubleSize < 1587 (start + pending_64_bit_constants_.size() * kDoubleSize <
1588 (first_const_pool_32_use_ + kMaxDistToIntPool))); 1588 static_cast<size_t>(first_const_pool_32_use_ +
1589 kMaxDistToIntPool)));
1589 DCHECK(pending_64_bit_constants_.empty() || 1590 DCHECK(pending_64_bit_constants_.empty() ||
1590 (start < (first_const_pool_64_use_ + kMaxDistToFPPool))); 1591 (start < (first_const_pool_64_use_ + kMaxDistToFPPool)));
1591 #endif 1592 #endif
1592 // Two cases: 1593 // Two cases:
1593 // * no_const_pool_before_ >= next_buffer_check_ and the emission is 1594 // * no_const_pool_before_ >= next_buffer_check_ and the emission is
1594 // still blocked 1595 // still blocked
1595 // * no_const_pool_before_ < next_buffer_check_ and the next emit will 1596 // * no_const_pool_before_ < next_buffer_check_ and the next emit will
1596 // trigger a check. 1597 // trigger a check.
1597 next_buffer_check_ = no_const_pool_before_; 1598 next_buffer_check_ = no_const_pool_before_;
1598 } 1599 }
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1708 explicit EnsureSpace(Assembler* assembler) { 1709 explicit EnsureSpace(Assembler* assembler) {
1709 assembler->CheckBuffer(); 1710 assembler->CheckBuffer();
1710 } 1711 }
1711 }; 1712 };
1712 1713
1713 1714
1714 } // namespace internal 1715 } // namespace internal
1715 } // namespace v8 1716 } // namespace v8
1716 1717
1717 #endif // V8_ARM_ASSEMBLER_ARM_H_ 1718 #endif // V8_ARM_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698