Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/compiler/pipeline.cc

Issue 2493173002: [turbofan] Fix more -Wsign-compare warnings. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-inlining-heuristic.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/pipeline.h" 5 #include "src/compiler/pipeline.h"
6 6
7 #include <fstream> // NOLINT(readability/streams) 7 #include <fstream> // NOLINT(readability/streams)
8 #include <memory> 8 #include <memory>
9 #include <sstream> 9 #include <sstream>
10 10
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 void InitializeInstructionSequence(const CallDescriptor* descriptor) { 267 void InitializeInstructionSequence(const CallDescriptor* descriptor) {
268 DCHECK(sequence_ == nullptr); 268 DCHECK(sequence_ == nullptr);
269 InstructionBlocks* instruction_blocks = 269 InstructionBlocks* instruction_blocks =
270 InstructionSequence::InstructionBlocksFor(instruction_zone(), 270 InstructionSequence::InstructionBlocksFor(instruction_zone(),
271 schedule()); 271 schedule());
272 sequence_ = new (instruction_zone()) InstructionSequence( 272 sequence_ = new (instruction_zone()) InstructionSequence(
273 info()->isolate(), instruction_zone(), instruction_blocks); 273 info()->isolate(), instruction_zone(), instruction_blocks);
274 if (descriptor && descriptor->RequiresFrameAsIncoming()) { 274 if (descriptor && descriptor->RequiresFrameAsIncoming()) {
275 sequence_->instruction_blocks()[0]->mark_needs_frame(); 275 sequence_->instruction_blocks()[0]->mark_needs_frame();
276 } else { 276 } else {
277 DCHECK_EQ(0, descriptor->CalleeSavedFPRegisters()); 277 DCHECK_EQ(0u, descriptor->CalleeSavedFPRegisters());
278 DCHECK_EQ(0, descriptor->CalleeSavedRegisters()); 278 DCHECK_EQ(0u, descriptor->CalleeSavedRegisters());
279 } 279 }
280 } 280 }
281 281
282 void InitializeFrameData(CallDescriptor* descriptor) { 282 void InitializeFrameData(CallDescriptor* descriptor) {
283 DCHECK(frame_ == nullptr); 283 DCHECK(frame_ == nullptr);
284 int fixed_frame_size = 0; 284 int fixed_frame_size = 0;
285 if (descriptor != nullptr) { 285 if (descriptor != nullptr) {
286 fixed_frame_size = descriptor->CalculateFixedFrameSize(); 286 fixed_frame_size = descriptor->CalculateFixedFrameSize();
287 } 287 }
288 frame_ = new (instruction_zone()) Frame(fixed_frame_size); 288 frame_ = new (instruction_zone()) Frame(fixed_frame_size);
(...skipping 1706 matching lines...) Expand 10 before | Expand all | Expand 10 after
1995 data->DeleteRegisterAllocationZone(); 1995 data->DeleteRegisterAllocationZone();
1996 } 1996 }
1997 1997
1998 CompilationInfo* PipelineImpl::info() const { return data_->info(); } 1998 CompilationInfo* PipelineImpl::info() const { return data_->info(); }
1999 1999
2000 Isolate* PipelineImpl::isolate() const { return info()->isolate(); } 2000 Isolate* PipelineImpl::isolate() const { return info()->isolate(); }
2001 2001
2002 } // namespace compiler 2002 } // namespace compiler
2003 } // namespace internal 2003 } // namespace internal
2004 } // namespace v8 2004 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-inlining-heuristic.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698