Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2492343003: Fix the WebGLObject arg non-nullable behaviors. (Closed)

Created:
4 years, 1 month ago by Zhenyao Mo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the WebGLObject arg non-nullable behaviors. BUG=662677 TEST=webgl_conformance,webgl2_conformance R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71e7b573616138859c7f9c76acae969be39a4f17 Cr-Commit-Position: refs/heads/master@{#431948}

Patch Set 1 #

Patch Set 2 : Fix the WebGLObject arg non-nullable behaviors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.idl View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Zhenyao Mo
Tested by test cases added in https://github.com/KhronosGroup/WebGL/pull/2146 Also, the crash in the bug is gone ...
4 years, 1 month ago (2016-11-12 02:34:04 UTC) #4
Ken Russell (switch to Gerrit)
Excellent work Mo. LGTM
4 years, 1 month ago (2016-11-14 17:39:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492343003/20001
4 years, 1 month ago (2016-11-14 19:03:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 23:08:44 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:12:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/71e7b573616138859c7f9c76acae969be39a4f17
Cr-Commit-Position: refs/heads/master@{#431948}

Powered by Google App Engine
This is Rietveld 408576698