Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2503593002: Roll WebGL bc2b06d..0028875 (Closed)

Created:
4 years, 1 month ago by Kai Ninomiya
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL bc2b06d..0028875 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/bc2b06d..0028875 BUG=639145 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/7fb2402f7eceb583b8f0ee1c86ffc1ce1735c897 Cr-Commit-Position: refs/heads/master@{#432075}

Patch Set 1 #

Patch Set 2 : set upstream #

Patch Set 3 : update expectations + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
Kai Ninomiya
zmo, PTAL
4 years, 1 month ago (2016-11-15 01:39:11 UTC) #12
Zhenyao Mo
On 2016/11/15 01:39:11, Kai Ninomiya wrote: > zmo, PTAL lgtm
4 years, 1 month ago (2016-11-15 01:41:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503593002/40001
4 years, 1 month ago (2016-11-15 01:42:09 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-15 03:38:55 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/7fb2402f7eceb583b8f0ee1c86ffc1ce1735c897 Cr-Commit-Position: refs/heads/master@{#432075}
4 years, 1 month ago (2016-11-15 03:43:29 UTC) #20
Geoff Lang
On 2016/11/15 03:43:29, commit-bot: I haz the power wrote: > Patchset 3 (id:??) landed as ...
4 years, 1 month ago (2016-11-15 15:06:48 UTC) #21
Geoff Lang
4 years, 1 month ago (2016-11-15 15:06:52 UTC) #22
Message was sent while issue was closed.
On 2016/11/15 03:43:29, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/7fb2402f7eceb583b8f0ee1c86ffc1ce1735c897
> Cr-Commit-Position: refs/heads/master@{#432075}

Kai, I think we also need expectations updates for the
WebglConformance_conformance2_glsl3_valid_invariant test on Linux Release AMD
R5/R7.  First failing build:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A...

Powered by Google App Engine
This is Rietveld 408576698