third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp - Issue 2492343003: Fix the WebGLObject arg non-nullable behaviors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp

Issue 2492343003: Fix the WebGLObject arg non-nullable behaviors. (Closed)

Patch Set: Fix the WebGLObject arg non-nullable behaviors. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQuery.idl ('k') | third_party/WebKit/Source/modules/webgl/WebGLDebugShaders.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp b/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp

index c7f9c42009fa0daf07fb3281ebff72e9a3fdb1ef..9c45d885191ddeba8037bccd2a7ff177fd8fc8ce 100644

--- a/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp

+++ b/third_party/WebKit/Source/modules/webgl/EXTDisjointTimerQueryWebGL2.cpp

@@ -38,7 +38,8 @@ void EXTDisjointTimerQueryWebGL2::queryCounterEXT(WebGLQuery* query,

if (scoped.isLost())

return;

- if (!query || query->isDeleted() ||

+ DCHECK(query);

+ if (query->isDeleted() ||

!query->validate(scoped.context()->contextGroup(), scoped.context())) {

scoped.context()->synthesizeGLError(GL_INVALID_OPERATION, "queryCounterEXT",

"invalid query");