Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2492283002: Mojo C++ bindings: switch components/filesystem mojom target to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
Reviewers:
Elliot Glaysher, erg
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch components/filesystem mojom target to use STL types. BUG=624136 TBR=ben@chromium.org for trivial changes outside of filesystem and leveldb Committed: https://crrev.com/cd0e2066fd5afd523d60c05890f6edcb52b099f7 Cr-Commit-Position: refs/heads/master@{#431959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -173 lines) Patch
M components/filesystem/directory_impl.h View 1 chunk +14 lines, -15 lines 0 comments Download
M components/filesystem/directory_impl.cc View 15 chunks +23 lines, -22 lines 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 6 chunks +16 lines, -13 lines 0 comments Download
M components/filesystem/file_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/file_impl.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M components/filesystem/file_impl_unittest.cc View 16 chunks +55 lines, -61 lines 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/filesystem/util.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/filesystem/util.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M components/leveldb/env_mojo.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M components/leveldb/leveldb_mojo_proxy.cc View 6 chunks +15 lines, -17 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M services/catalog/public/cpp/resource_loader.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yzshen1
Hi, Elliot. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-11 18:50:36 UTC) #4
Elliot Glaysher
lgtm
4 years, 1 month ago (2016-11-14 18:16:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492283002/1
4 years, 1 month ago (2016-11-14 18:21:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 23:20:23 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:33:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd0e2066fd5afd523d60c05890f6edcb52b099f7
Cr-Commit-Position: refs/heads/master@{#431959}

Powered by Google App Engine
This is Rietveld 408576698