components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc - Issue 2492283002: Mojo C++ bindings: switch components/filesystem mojom target to use STL types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

Issue 2492283002: Mojo C++ bindings: switch components/filesystem mojom target to use STL types. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h ('k') | components/filesystem/public/interfaces/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

diff --git a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

index 74638b0c65d90be72e5b0e0b664cd2588d4d803b..0a5d66091f6286c41ed4be687e0c6ba26b93b4b6 100644

--- a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

+++ b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc

@@ -391,7 +391,7 @@ void FilesystemJsonPrefStore::OnPreferencesReadStart() {

void FilesystemJsonPrefStore::OnPreferencesFileRead(

mojom::FileError err,

- mojo::Array<uint8_t> contents) {

+ const std::vector<uint8_t>& contents) {

std::unique_ptr<FilesystemJsonPrefStore::ReadResult> read_result(

new FilesystemJsonPrefStore::ReadResult);

// TODO(erg): Needs even better error handling.