components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h - Issue 2492283002: Mojo C++ bindings: switch components/filesystem mojom target to use STL types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h

Issue 2492283002: Mojo C++ bindings: switch components/filesystem mojom target to use STL types. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/filesystem/file_impl_unittest.cc ('k') | components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h

diff --git a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h

index 0ea0d93dd7415ae63656ea40a194fed4e8d8aefc..d52b0ec1c2f56d635f62177dc749225e4c88d4d6 100644

--- a/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h

+++ b/components/filesystem/public/cpp/prefs/filesystem_json_pref_store.h

@@ -148,7 +148,7 @@ class FilesystemJsonPrefStore

// Asynchronous implementation details of ReadPrefsAsync().

void OnPreferencesReadStart();

void OnPreferencesFileRead(mojom::FileError err,

- mojo::Array<uint8_t> contents);

+ const std::vector<uint8_t>& contents);

const std::string path_;

mojo::Binding<filesystem::mojom::FileSystemClient> binding_;