Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: components/filesystem/util.h

Issue 2492283002: Mojo C++ bindings: switch components/filesystem mojom target to use STL types. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/public/interfaces/BUILD.gn ('k') | components/filesystem/util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/util.h
diff --git a/components/filesystem/util.h b/components/filesystem/util.h
index 464565fc3fe8f18a3013aa6759734ef1ec56d1fb..b00fcf56f0dd2e4be1ce7d1054b4b5e2b1e356a6 100644
--- a/components/filesystem/util.h
+++ b/components/filesystem/util.h
@@ -20,10 +20,10 @@ namespace filesystem {
// |ERROR_OK| if valid, else the standard/recommended error for the validation
// error):
-// Checks if |path|, which must be non-null, is (looks like) a valid (relative)
-// path. (On failure, returns |ERROR_INVALID_ARGUMENT| if |path| is not UTF-8,
-// or |ERROR_PERMISSION_DENIED| if it is not relative.)
-mojom::FileError IsPathValid(const mojo::String& path);
+// Checks if |path| is (looks like) a valid (relative) path. (On failure,
+// returns |ERROR_INVALID_ARGUMENT| if |path| is not UTF-8, or
+// |ERROR_PERMISSION_DENIED| if it is not relative.)
+mojom::FileError IsPathValid(const std::string& path);
// Checks if |whence| is a valid (known) |Whence| value. (On failure, returns
// |ERROR_UNIMPLEMENTED|.)
@@ -44,7 +44,7 @@ mojom::FileError GetError(const base::File& file);
mojom::FileInformationPtr MakeFileInformation(const base::File::Info& info);
// Creates an absolute file path and ensures that we don't try to traverse up.
-mojom::FileError ValidatePath(const mojo::String& raw_path,
+mojom::FileError ValidatePath(const std::string& raw_path,
const base::FilePath& filesystem_base,
base::FilePath* out);
« no previous file with comments | « components/filesystem/public/interfaces/BUILD.gn ('k') | components/filesystem/util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698