Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2488833005: Remove support for old naming convention for EarlGrey tests on iOS. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
Reviewers:
*baxley, *smut
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for old naming convention for EarlGrey tests on iOS. BUG=662404 Committed: https://crrev.com/53de6b93990e7502327f2becb787e9a9352a645e Cr-Commit-Position: refs/heads/master@{#431395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -36 lines) Patch
M build/config/ios/rules.gni View 1 chunk +9 lines, -16 lines 0 comments Download
M ios/build/bots/scripts/test_runner.py View 1 chunk +1 line, -10 lines 0 comments Download
M ios/build/tools/convert_gn_xcodeproj.py View 1 chunk +2 lines, -6 lines 0 comments Download
M ios/web/shell/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sdefresne
baxley: please take a look. smut: OWNERS of ios/build/bots/scripts/test_runner.py.
4 years, 1 month ago (2016-11-09 16:17:53 UTC) #5
baxley
lgtm
4 years, 1 month ago (2016-11-09 17:06:11 UTC) #6
smut
lgtm
4 years, 1 month ago (2016-11-10 22:24:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2488833005/1
4 years, 1 month ago (2016-11-10 22:25:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 23:21:41 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 23:28:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53de6b93990e7502327f2becb787e9a9352a645e
Cr-Commit-Position: refs/heads/master@{#431395}

Powered by Google App Engine
This is Rietveld 408576698