Remove support for old naming convention for EarlGrey tests on iOS.

ios/build/tools/convert_gn_xcodeproj.py

 #!/usr/bin/python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Convert GN Xcode projects to platform and configuration independent targets.
 
 GN generates Xcode projects that build one configuration only. However, typical
 iOS development involves using the Xcode IDE to toggle the platform and
 configuration. This script replaces the 'gn' configuration with 'Debug',
@@ skipping 104 matching lines @@
     # Configure BUNDLE_LOADER and TEST_HOST for xctest targets (if not yet
     # configured by gn). Old convention was to name the test dynamic module
     # "foo" and the host "foo_host" while the new convention is to name the
     # test "foo_module" and the host "foo". Decide which convention to use
     # by inspecting the target name.
     if isa == 'PBXNativeTarget' and value['productType'] == XCTEST_PRODUCT_TYPE:
       configuration_list = project.objects[value['buildConfigurationList']]
       for config_name in configuration_list['buildConfigurations']:
         config = project.objects[config_name]
         if not config['buildSettings'].get('BUNDLE_LOADER'):
-          if value['name'].endswith('_module'):
-            host_name = value['name'][:-len('_module')]
-          else:
-            # TODO(crbug.com/662404): remove once the targets have been renamed
-            # to use the new naming convention.
-            host_name = value['name'] + '_host'
+          assert value['name'].endswith('_module')
+          host_name = value['name'][:-len('_module')]
           config['buildSettings']['BUNDLE_LOADER'] = '$(TEST_HOST)'
           config['buildSettings']['TEST_HOST'] = \
               '${BUILT_PRODUCTS_DIR}/%s.app/%s' % (host_name, host_name)
 
     # Add new configuration, using the first one as default.
     if isa == 'XCConfigurationList':
       value['defaultConfigurationName'] = configurations[0]
       objects_to_remove.extend(value['buildConfigurations'])
 
       build_config_template = project.objects[value['buildConfigurations'][0]]
@@ skipping 72 matching lines @@
   if not args.configurations:
     sys.stderr.write('At least one configuration required, see --add-config.\n')
     return 1
 
   ConvertGnXcodeProject(args.input, args.output, args.configurations)
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv[1:]))