Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: ios/build/tools/convert_gn_xcodeproj.py

Issue 2488833005: Remove support for old naming convention for EarlGrey tests on iOS. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/build/bots/scripts/test_runner.py ('k') | ios/web/shell/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/build/tools/convert_gn_xcodeproj.py
diff --git a/ios/build/tools/convert_gn_xcodeproj.py b/ios/build/tools/convert_gn_xcodeproj.py
index a5d6209438c9bbc721e25c73d9109add56cd46c0..668104f6e3b2d9f4a4445949cc90420924a68a50 100755
--- a/ios/build/tools/convert_gn_xcodeproj.py
+++ b/ios/build/tools/convert_gn_xcodeproj.py
@@ -122,12 +122,8 @@ def UpdateProductsProject(file_input, file_output, configurations):
for config_name in configuration_list['buildConfigurations']:
config = project.objects[config_name]
if not config['buildSettings'].get('BUNDLE_LOADER'):
- if value['name'].endswith('_module'):
- host_name = value['name'][:-len('_module')]
- else:
- # TODO(crbug.com/662404): remove once the targets have been renamed
- # to use the new naming convention.
- host_name = value['name'] + '_host'
+ assert value['name'].endswith('_module')
+ host_name = value['name'][:-len('_module')]
config['buildSettings']['BUNDLE_LOADER'] = '$(TEST_HOST)'
config['buildSettings']['TEST_HOST'] = \
'${BUILT_PRODUCTS_DIR}/%s.app/%s' % (host_name, host_name)
« no previous file with comments | « ios/build/bots/scripts/test_runner.py ('k') | ios/web/shell/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698