Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: ios/build/bots/scripts/test_runner.py

Issue 2488833005: Remove support for old naming convention for EarlGrey tests on iOS. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/ios/rules.gni ('k') | ios/build/tools/convert_gn_xcodeproj.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/build/bots/scripts/test_runner.py
diff --git a/ios/build/bots/scripts/test_runner.py b/ios/build/bots/scripts/test_runner.py
index e1e356ae46eb745a235a59e37e1a966faca7c1ad..b5f647b3b9b3ad928e5933b2cbcba60d612fa024 100644
--- a/ios/build/bots/scripts/test_runner.py
+++ b/ios/build/bots/scripts/test_runner.py
@@ -675,15 +675,6 @@ class DeviceTestRunner(TestRunner):
# e.g. ios_web_shell_egtests
env['APP_TARGET_NAME'] = os.path.splitext(
os.path.basename(self.app_path))[0]
-
- # Two convention for the test name have been in use. Old convention was to
- # use the host name without _host suffix while the new convention is to
- # use host name with _module suffix. As new convention does not use _host
- # suffix its presence can be used to determine correct name for the test
- # target. TODO(crbug.com/662404): remove once only new convention is used.
# e.g. ios_web_shell_egtests_module
- if env['APP_TARGET_NAME'].endswith('_host'):
- env['TEST_TARGET_NAME'] = env['APP_TARGET_NAME'].rsplit('_', 1)[0]
- else:
- env['TEST_TARGET_NAME'] = env['APP_TARGET_NAME'] + '_module'
+ env['TEST_TARGET_NAME'] = env['APP_TARGET_NAME'] + '_module'
return env
« no previous file with comments | « build/config/ios/rules.gni ('k') | ios/build/tools/convert_gn_xcodeproj.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698