Asserting telemetry story display name length for filename creation.

Asserting telemetry story display name length for filename creation.

BUG=chromium:662941
Review-Url: https://codereview.chromium.org/2488743006
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/6342064cf8ddf225cd7f73d60eca3a7de740dcb7

[eyaich1, 2016-11-10 16:22:19]

eyaich@chromium.org changed reviewers:
+ eakuefner@chromium.org

[eakuefner, 2016-11-17 17:05:50]

lgtm

https://codereview.chromium.org/2488743006/diff/20001/telemetry/telemetry/pag...
File telemetry/telemetry/page/__init__.py (right):

https://codereview.chromium.org/2488743006/diff/20001/telemetry/telemetry/pag...
telemetry/telemetry/page/__init__.py:70: # filename isn't too long. See
crbug.com/662941
nit: end with .

https://codereview.chromium.org/2488743006/diff/20001/telemetry/telemetry/pag...
File telemetry/telemetry/page/page_unittest.py (right):

https://codereview.chromium.org/2488743006/diff/20001/telemetry/telemetry/pag...
telemetry/telemetry/page/page_unittest.py:52: except Exception:
Please use self.assertRaises[0] instead of this pattern.

[0]
https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaises

[eakuefner, 2017-01-04 19:42:45]

ping :)

[eyaich1, 2017-01-04 19:59:46]

https://codereview.chromium.org/2488743006/diff/20001/telemetry/telemetry/pag...
File telemetry/telemetry/page/__init__.py (right):

https://codereview.chromium.org/2488743006/diff/20001/telemetry/telemetry/pag...
telemetry/telemetry/page/__init__.py:70: # filename isn't too long. See
crbug.com/662941
On 2016/11/17 17:05:50, eakuefner wrote:
> nit: end with .

Done.

https://codereview.chromium.org/2488743006/diff/20001/telemetry/telemetry/pag...
File telemetry/telemetry/page/page_unittest.py (right):

https://codereview.chromium.org/2488743006/diff/20001/telemetry/telemetry/pag...
telemetry/telemetry/page/page_unittest.py:52: except Exception:
On 2016/11/17 17:05:50, eakuefner wrote:
> Please use self.assertRaises[0] instead of this pattern.
> 
> [0]
> https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaises

Done.

[eyaich1, 2017-01-04 19:59:51]

The CQ bit was checked by eyaich@chromium.org

[eyaich1, 2017-01-04 19:59:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2488743006/#ps40001
(title: "Responding to review comments")

[commit-bot: I haz the power, 2017-01-04 19:59:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:18:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483559991603690,
"parent_rev": "247c79d05bdf641ca0283d04870826008b5294fb", "commit_rev":
"6342064cf8ddf225cd7f73d60eca3a7de740dcb7"}

[commit-bot: I haz the power, 2017-01-04 20:18:23]

Description was changed from

==========
Asserting telemetry story display name length for filename creation.

BUG=chromium:662941
==========

to

==========
Asserting telemetry story display name length for filename creation.

BUG=chromium:662941

Review-Url: https://codereview.chromium.org/2488743006
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-01-04 20:18:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[nednguyen, 2017-01-06 01:51:02]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2610173005/ by nednguyen@google.com.

The reason for reverting is: This is breaking some stories in tools/perf/ &
caused catapult roll blockage (https://codereview.chromium.org/2617583004).

Anyhow, those stories with long name in tools/perf should be fixed, but we
should still send an announcement to telemetry-announce@ before landing this..