telemetry/telemetry/page/__init__.py - Issue 2488743006: Asserting telemetry story display name length for filename creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/init.py

Issue 2488743006: Asserting telemetry story display name length for filename creation. (Closed)

Patch Set: Responding to review comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/__init__.py

diff --git a/telemetry/telemetry/page/__init__.py b/telemetry/telemetry/page/__init__.py

index 5c0e5db9b2b7c334090aefba3188925e08f5f356..ce9f7916f26cc0221e3e530ec2ee6b17e9cb0ab5 100644

--- a/telemetry/telemetry/page/__init__.py

+++ b/telemetry/telemetry/page/__init__.py

@@ -68,6 +68,9 @@ class Page(story.Story):

self.skip_waits = False

self.script_to_evaluate_on_commit = None

self._SchemeErrorCheck()

+ # Confirm that the display name length that is used to generate the trace

+ # filename isn't too long. See crbug.com/662941.

+ assert len(self.display_name) <= 180

@property

def credentials_path(self):

« no previous file with comments | « no previous file | telemetry/telemetry/page/page_unittest.py » ('j') | no next file with comments »