Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: telemetry/telemetry/page/page_unittest.py

Issue 2488743006: Asserting telemetry story display name length for filename creation. (Closed)
Patch Set: Responding to review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/page/__init__.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/page/page_unittest.py
diff --git a/telemetry/telemetry/page/page_unittest.py b/telemetry/telemetry/page/page_unittest.py
index 76204650ceb56bd9a3897ef9f73ed453675fdc8e..d4e234adf087d3840d5e6337d0d88a075857a28b 100644
--- a/telemetry/telemetry/page/page_unittest.py
+++ b/telemetry/telemetry/page/page_unittest.py
@@ -44,6 +44,19 @@ class TestPage(unittest.TestCase):
self.assertTrue(apage.file_path_url.endswith(os.sep) or
(os.altsep and apage.file_path_url.endswith(os.altsep)))
+ def testNameTooLong(self):
+ long_name = 'x' * 260
+ with self.assertRaises(Exception):
+ page.Page('file://somedir/otherdir/',
+ None, base_dir='basedir', name=long_name)
+
+ def testUrlTooLong(self):
+ long_name = 'x' * 260
+ long_url = 'file://somedir/otherdir/%s' % long_name
+ with self.assertRaises(Exception):
+ page.Page(long_url,
+ None, base_dir='basedir')
+
def testSort(self):
story_set = story.StorySet(base_dir=os.path.dirname(__file__))
story_set.AddStory(
« no previous file with comments | « telemetry/telemetry/page/__init__.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698