[inspector] Add exception caught/uncaught status to protocol

[inspector] Add exception caught/uncaught status to protocol

This adds information about an exception's caught/uncaught status to the
Runtime.paused event in the data parameter:

{
    "method": "Debugger.paused",
    "params": {
        "callFrames": [
	    [...]
        ],
        "data": {
            "description": "666",
            "type": "number",
            "uncaught": true,  <---
            "value": 666
        },
        "hitBreakpoints": [],
        "reason": "exception"
    }
}

BUG=v8:5530
Committed: https://crrev.com/fab116be0e4e456a6e023488db271ce3ddf1d615
Cr-Commit-Position: refs/heads/master@{#40875}

[jgruber, 2016-11-09 11:36:43]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 11:36:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 11:40:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:40:26]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/12165)

[jgruber, 2016-11-09 11:41:40]

jgruber@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[jgruber, 2016-11-09 11:41:41]

My first go at this, PTAL.

[Yang, 2016-11-09 11:45:07]

On 2016/11/09 11:41:41, jgruber wrote:
> My first go at this, PTAL.

I'm a bit surprised that you did not have to change js_protocol-1.2.json

[jgruber, 2016-11-09 11:48:08]

On 2016/11/09 11:45:07, Yang wrote:
> On 2016/11/09 11:41:41, jgruber wrote:
> > My first go at this, PTAL.
> 
> I'm a bit surprised that you did not have to change js_protocol-1.2.json

The contents of the data field are unspecified:

{ "name": "data", "type": "object", "optional": true, "description": "Object
containing break-specific auxiliary properties." },

[jgruber, 2016-11-09 11:48:32]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 11:48:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 12:14:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 12:14:12]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-09 16:22:21]

On 2016/11/09 11:48:08, jgruber wrote:
> On 2016/11/09 11:45:07, Yang wrote:
> > On 2016/11/09 11:41:41, jgruber wrote:
> > > My first go at this, PTAL.
> > 
> > I'm a bit surprised that you did not have to change js_protocol-1.2.json
> 
> The contents of the data field are unspecified:
> 
> { "name": "data", "type": "object", "optional": true, "description": "Object
> containing break-specific auxiliary properties." },

js_protocol-1.2 captures the state of protocol which we commit to support.
Adding fields does not break backwards compatibility, so it should not complain
even if "data" was typed.

[dgozman, 2016-11-09 16:27:48]

https://codereview.chromium.org/2488733003/diff/20001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2488733003/diff/20001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:1126:
m_breakAuxData->setBoolean("uncaught", isUncaught);
To be very clean, we'd better pass uncaught alongside the wrapped exception, not
as a field of it. But this would work as well.

[kozy, 2016-11-09 17:38:13]

lgtm

[jgruber, 2016-11-10 07:55:52]

https://codereview.chromium.org/2488733003/diff/20001/src/inspector/v8-debugg...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2488733003/diff/20001/src/inspector/v8-debugg...
src/inspector/v8-debugger-agent-impl.cc:1126:
m_breakAuxData->setBoolean("uncaught", isUncaught);
On 2016/11/09 16:27:48, dgozman wrote:
> To be very clean, we'd better pass uncaught alongside the wrapped exception,
not
> as a field of it. But this would work as well.

Agreed, but wouldn't that break backwards compatibility for current users of the
data field? If you don't mind I'll land this as is, but I'm open to
restructuring data as 

{ data: { exception : [...],
          uncaught : [...]
}

[jgruber, 2016-11-10 07:56:28]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-11-10 07:56:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 07:58:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:28:13]

Description was changed from

==========
[inspector] Add exception caught/uncaught status to protocol

This adds information about an exception's caught/uncaught status to the
Runtime.paused event in the data parameter:

{
    "method": "Debugger.paused",
    "params": {
        "callFrames": [
	    [...]
        ],
        "data": {
            "description": "666",
            "type": "number",
            "uncaught": true,  <---
            "value": 666
        },
        "hitBreakpoints": [],
        "reason": "exception"
    }
}

BUG=v8:5530
==========

to

==========
[inspector] Add exception caught/uncaught status to protocol

This adds information about an exception's caught/uncaught status to the
Runtime.paused event in the data parameter:

{
    "method": "Debugger.paused",
    "params": {
        "callFrames": [
	    [...]
        ],
        "data": {
            "description": "666",
            "type": "number",
            "uncaught": true,  <---
            "value": 666
        },
        "hitBreakpoints": [],
        "reason": "exception"
    }
}

BUG=v8:5530

Committed: https://crrev.com/fab116be0e4e456a6e023488db271ce3ddf1d615
Cr-Commit-Position: refs/heads/master@{#40875}
==========

[commit-bot: I haz the power, 2016-11-17 22:28:14]

Patchset 2 (id:??) landed as
https://crrev.com/fab116be0e4e456a6e023488db271ce3ddf1d615
Cr-Commit-Position: refs/heads/master@{#40875}