src/inspector/v8-debugger-agent-impl.h - Issue 2488733003: [inspector] Add exception caught/uncaught status to protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/v8-debugger-agent-impl.h

Issue 2488733003: [inspector] Add exception caught/uncaught status to protocol (Closed)

Patch Set: Use Maybe version of BooleanValue Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/v8-debugger-agent-impl.h

diff --git a/src/inspector/v8-debugger-agent-impl.h b/src/inspector/v8-debugger-agent-impl.h

index 79ad1e27bc37aa8d193f8e3a32b7998878135e91..e5285f4cc31c43525ab6b0c47c396f1da2a4d492 100644

--- a/src/inspector/v8-debugger-agent-impl.h

+++ b/src/inspector/v8-debugger-agent-impl.h

@@ -137,7 +137,7 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {

SkipPauseRequest didPause(v8::Local<v8::Context>,

v8::Local<v8::Value> exception,

const std::vector<String16>& hitBreakpoints,

- bool isPromiseRejection);

+ bool isPromiseRejection, bool isUncaught);

void didContinue();

void didParseSource(std::unique_ptr<V8DebuggerScript>, bool success);

void willExecuteScript(int scriptId);