Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2480293009: [debug-wrapper] Add caught/uncaught to exception pauses (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] Add caught/uncaught to exception pauses BUG=v8:5530 Committed: https://crrev.com/3098e2490964dc21848caa281876b62342f8d8d4 Cr-Commit-Position: refs/heads/master@{#40877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -165 lines) Patch
A + test/debugger/debug/debug-event-listener.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/debug-exceptions.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/debug/es6/debug-promises/stepin-handler.js View 1 chunk +1 line, -1 line 0 comments Download
M test/debugger/test-api.js View 1 chunk +5 lines, -0 lines 0 comments Download
D test/mjsunit/debug-event-listener.js View 1 chunk +0 lines, -73 lines 0 comments Download
D test/mjsunit/debug-exceptions.js View 1 chunk +0 lines, -88 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 1 month ago (2016-11-10 08:01:58 UTC) #6
Yang
On 2016/11/10 08:01:58, jgruber wrote: lgtm
4 years, 1 month ago (2016-11-10 08:43:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480293009/1
4 years, 1 month ago (2016-11-10 09:03:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 09:05:15 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:28:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3098e2490964dc21848caa281876b62342f8d8d4
Cr-Commit-Position: refs/heads/master@{#40877}

Powered by Google App Engine
This is Rietveld 408576698