[inspector] Add exception caught/uncaught status to protocol

src/inspector/v8-debugger-agent-impl.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/v8-debugger-agent-impl.h"
 
 #include <algorithm>
 
 #include "src/debug/debug-interface.h"
 #include "src/inspector/injected-script.h"
@@ skipping 1060 matching lines @@
                                 &breakpoint.condition);
     std::unique_ptr<protocol::Debugger::Location> location = resolveBreakpoint(
         cookie.first, scriptId, breakpoint, UserBreakpointSource);
     if (location)
       m_frontend.breakpointResolved(cookie.first, std::move(location));
   }
 }
 
 V8DebuggerAgentImpl::SkipPauseRequest V8DebuggerAgentImpl::didPause(
     v8::Local<v8::Context> context, v8::Local<v8::Value> exception,
-    const std::vector<String16>& hitBreakpoints, bool isPromiseRejection) {
+    const std::vector<String16>& hitBreakpoints, bool isPromiseRejection,
+    bool isUncaught) {
   JavaScriptCallFrames callFrames = m_debugger->currentCallFrames(1);
   JavaScriptCallFrame* topCallFrame =
       !callFrames.empty() ? callFrames.begin()->get() : nullptr;
 
   V8DebuggerAgentImpl::SkipPauseRequest result;
   if (m_skipAllPauses)
     result = RequestContinue;
   else if (!hitBreakpoints.empty())
     result = RequestNoSkip;  // Don't skip explicit breakpoints even if set in
                              // frameworks.
@@ skipping 21 matching lines @@
     m_session->findInjectedScript(V8Debugger::contextId(context),
                                   injectedScript);
     if (injectedScript) {
       m_breakReason =
           isPromiseRejection
               ? protocol::Debugger::Paused::ReasonEnum::PromiseRejection
               : protocol::Debugger::Paused::ReasonEnum::Exception;
       std::unique_ptr<protocol::Runtime::RemoteObject> obj;
       injectedScript->wrapObject(exception, kBacktraceObjectGroup, false, false,
                                  &obj);
-      m_breakAuxData = obj ? obj->serialize() : nullptr;
+      if (obj) {
+        m_breakAuxData = obj->serialize();
+        m_breakAuxData->setBoolean("uncaught", isUncaught);

[dgozman, 2016/11/09 16:27:48]

To be very clean, we'd better pass uncaught alongside the wrapped exception, not
as a field of it. But this would work as well.

[jgruber, 2016/11/10 07:55:52]

Agreed, but wouldn't that break backwards compatibility for current users of the
data field? If you don't mind I'll land this as is, but I'm open to
restructuring data as 

{ data: { exception : [...],
          uncaught : [...]
}

+      } else {
+        m_breakAuxData = nullptr;
+      }
       // m_breakAuxData might be null after this.
     }
   }
 
   std::unique_ptr<Array<String16>> hitBreakpointIds = Array<String16>::create();
 
   for (const auto& point : hitBreakpoints) {
     DebugServerBreakpointToBreakpointIdAndSourceMap::iterator
         breakpointIterator = m_serverBreakpoints.find(point);
     if (breakpointIterator != m_serverBreakpoints.end()) {
@@ skipping 84 matching lines @@
 
 void V8DebuggerAgentImpl::reset() {
   if (!enabled()) return;
   m_scheduledDebuggerStep = NoStep;
   m_scripts.clear();
   m_blackboxedPositions.clear();
   m_breakpointIdToDebuggerBreakpointIds.clear();
 }
 
 }  // namespace v8_inspector