Service Manager: Remove ServiceContext* arg from Service::OnStart()

Service Manager: Remove ServiceContext* arg from Service::OnStart()

This restores the context() accessor to Service, but now
guarantees that ServiceContext always sets the context
before invoking OnStart().

This means that all Service implementations are free to safely
access context() any time after OnStart() regardless of what
service-running mechanism was used to create their
ServiceContext.

BUG=654986
Committed: https://crrev.com/6d9b6cd9869d3f8385a42b3272edd7f5b3a6ac5e
Committed: https://crrev.com/4b5e64d3c7aadaffe9131291fe503a46ea0809d3
Cr-Original-Commit-Position: refs/heads/master@{#431752}
Cr-Commit-Position: refs/heads/master@{#431778}

[Ken Rockot(use gerrit already), 2016-11-08 00:48:26]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 00:49:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 00:54:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 00:54:19]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-11-08 00:56:58]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 00:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-08 01:05:13]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ken Rockot(use gerrit already), 2016-11-08 01:05:14]

churn churn churn - tl;dr rationale: because ServiceContext now owns Service, we
can guarantee that set_context() is always called before OnStart(), and
therefore it's ok to restore set_context()/context() on Service.

[commit-bot: I haz the power, 2016-11-08 01:13:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 01:13:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ken Rockot(use gerrit already), 2016-11-08 01:28:11]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 01:28:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-11-08 01:37:22]

rubber stamp lgtm

[commit-bot: I haz the power, 2016-11-08 01:51:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 01:51:01]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)

[Ken Rockot(use gerrit already), 2016-11-10 23:25:56]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 23:26:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:41:38]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ken Rockot(use gerrit already), 2016-11-11 21:10:29]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 21:10:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-11 21:11:03]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-11 21:11:05]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-11 21:11:06]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2487573002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-11-11 21:11:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 21:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 21:14:29]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2016-11-11 22:02:46]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 22:03:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-11 23:14:57]

Description was changed from

==========
Remove ServiceContext* argument from OnStart()

This restores the context() accessor to Service, but now
guarantees that ServiceContext always sets the context
before invoking OnStart().

This means that all Service implementations are free to safely
access context() any time after OnStart() regardless of what
service-running mechanism was used to create their
ServiceContext.

BUG=654986
==========

to

==========
Service Manager: Remove ServiceContext* arg from Service::OnStart()

This restores the context() accessor to Service, but now
guarantees that ServiceContext always sets the context
before invoking OnStart().

This means that all Service implementations are free to safely
access context() any time after OnStart() regardless of what
service-running mechanism was used to create their
ServiceContext.

BUG=654986
==========

[commit-bot: I haz the power, 2016-11-11 23:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 23:52:59]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-11-12 00:16:27]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-12 00:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2487573002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-12 00:16:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:27:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 00:27:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2016-11-12 00:33:46]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 00:34:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 02:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 02:08:51]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-11-12 02:28:54]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-12 02:28:55]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2487573002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-12 02:29:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 02:35:22]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-12 02:37:37]

Description was changed from

==========
Service Manager: Remove ServiceContext* arg from Service::OnStart()

This restores the context() accessor to Service, but now
guarantees that ServiceContext always sets the context
before invoking OnStart().

This means that all Service implementations are free to safely
access context() any time after OnStart() regardless of what
service-running mechanism was used to create their
ServiceContext.

BUG=654986
==========

to

==========
Service Manager: Remove ServiceContext* arg from Service::OnStart()

This restores the context() accessor to Service, but now
guarantees that ServiceContext always sets the context
before invoking OnStart().

This means that all Service implementations are free to safely
access context() any time after OnStart() regardless of what
service-running mechanism was used to create their
ServiceContext.

BUG=654986

Committed: https://crrev.com/6d9b6cd9869d3f8385a42b3272edd7f5b3a6ac5e
Cr-Commit-Position: refs/heads/master@{#431752}
==========

[commit-bot: I haz the power, 2016-11-12 02:37:39]

Patchset 7 (id:??) landed as
https://crrev.com/6d9b6cd9869d3f8385a42b3272edd7f5b3a6ac5e
Cr-Commit-Position: refs/heads/master@{#431752}

[Ken Rockot(use gerrit already), 2016-11-12 02:56:52]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2494303002/ by rockot@chromium.org.

The reason for reverting is: Compile failure, conflicting with another CL.

[Ken Rockot(use gerrit already), 2016-11-12 02:57:04]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2500683002/ by rockot@chromium.org.

The reason for reverting is: Compile failure, conflicting with another CL.

[findit-for-me, 2016-11-12 03:11:18]

FYI: Findit identified this CL at revision 431752 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Ken Rockot(use gerrit already), 2016-11-12 05:43:21]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 05:43:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-11-12 05:43:30]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-12 05:43:32]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-11-12 05:43:33]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2487573002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-12 05:43:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 07:48:30]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-12 07:50:16]

Description was changed from

==========
Service Manager: Remove ServiceContext* arg from Service::OnStart()

This restores the context() accessor to Service, but now
guarantees that ServiceContext always sets the context
before invoking OnStart().

This means that all Service implementations are free to safely
access context() any time after OnStart() regardless of what
service-running mechanism was used to create their
ServiceContext.

BUG=654986

Committed: https://crrev.com/6d9b6cd9869d3f8385a42b3272edd7f5b3a6ac5e
Cr-Commit-Position: refs/heads/master@{#431752}
==========

to

==========
Service Manager: Remove ServiceContext* arg from Service::OnStart()

This restores the context() accessor to Service, but now
guarantees that ServiceContext always sets the context
before invoking OnStart().

This means that all Service implementations are free to safely
access context() any time after OnStart() regardless of what
service-running mechanism was used to create their
ServiceContext.

BUG=654986

Committed: https://crrev.com/6d9b6cd9869d3f8385a42b3272edd7f5b3a6ac5e
Committed: https://crrev.com/4b5e64d3c7aadaffe9131291fe503a46ea0809d3
Cr-Original-Commit-Position: refs/heads/master@{#431752}
Cr-Commit-Position: refs/heads/master@{#431778}
==========

[commit-bot: I haz the power, 2016-11-12 07:50:18]

Patchset 8 (id:??) landed as
https://crrev.com/4b5e64d3c7aadaffe9131291fe503a46ea0809d3
Cr-Commit-Position: refs/heads/master@{#431778}