Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: services/image_decoder/image_decoder_service.cc

Issue 2487573002: Service Manager: Remove ServiceContext* arg from Service::OnStart() (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/image_decoder/image_decoder_service.h ('k') | services/navigation/navigation.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/image_decoder/image_decoder_service.h" 5 #include "services/image_decoder/image_decoder_service.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "mojo/public/cpp/bindings/strong_binding.h" 8 #include "mojo/public/cpp/bindings/strong_binding.h"
9 #include "services/image_decoder/image_decoder_impl.h" 9 #include "services/image_decoder/image_decoder_impl.h"
10 #include "services/image_decoder/public/interfaces/image_decoder.mojom.h" 10 #include "services/image_decoder/public/interfaces/image_decoder.mojom.h"
(...skipping 21 matching lines...) Expand all
32 32
33 ImageDecoderService::ImageDecoderService() = default; 33 ImageDecoderService::ImageDecoderService() = default;
34 34
35 ImageDecoderService::~ImageDecoderService() = default; 35 ImageDecoderService::~ImageDecoderService() = default;
36 36
37 // static 37 // static
38 std::unique_ptr<service_manager::Service> ImageDecoderService::Create() { 38 std::unique_ptr<service_manager::Service> ImageDecoderService::Create() {
39 return base::MakeUnique<ImageDecoderService>(); 39 return base::MakeUnique<ImageDecoderService>();
40 } 40 }
41 41
42 void ImageDecoderService::OnStart(service_manager::ServiceContext* context) { 42 void ImageDecoderService::OnStart() {
43 ref_factory_.reset(new service_manager::ServiceContextRefFactory( 43 ref_factory_.reset(new service_manager::ServiceContextRefFactory(
44 base::Bind(&service_manager::ServiceContext::RequestQuit, 44 base::Bind(&service_manager::ServiceContext::RequestQuit,
45 base::Unretained(context)))); 45 base::Unretained(context()))));
46 } 46 }
47 47
48 bool ImageDecoderService::OnConnect( 48 bool ImageDecoderService::OnConnect(
49 const service_manager::ServiceInfo& remote_info, 49 const service_manager::ServiceInfo& remote_info,
50 service_manager::InterfaceRegistry* registry) { 50 service_manager::InterfaceRegistry* registry) {
51 // Add a reference to the service and tie it to the lifetime of the 51 // Add a reference to the service and tie it to the lifetime of the
52 // InterfaceRegistry's connection. 52 // InterfaceRegistry's connection.
53 std::unique_ptr<service_manager::ServiceContextRef> connection_ref = 53 std::unique_ptr<service_manager::ServiceContextRef> connection_ref =
54 ref_factory_->CreateRef(); 54 ref_factory_->CreateRef();
55 registry->AddConnectionLostClosure( 55 registry->AddConnectionLostClosure(
56 base::Bind(&OnConnectionLost, base::Passed(&connection_ref))); 56 base::Bind(&OnConnectionLost, base::Passed(&connection_ref)));
57 registry->AddInterface( 57 registry->AddInterface(
58 base::Bind(&OnImageDecoderRequest, ref_factory_.get())); 58 base::Bind(&OnImageDecoderRequest, ref_factory_.get()));
59 return true; 59 return true;
60 } 60 }
61 61
62 bool ImageDecoderService::OnStop() { 62 bool ImageDecoderService::OnStop() {
63 return true; 63 return true;
64 } 64 }
65 65
66 } // namespace image_decoder 66 } // namespace image_decoder
OLDNEW
« no previous file with comments | « services/image_decoder/image_decoder_service.h ('k') | services/navigation/navigation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698