services/service_manager/tests/lifecycle/app_client.h - Issue 2487573002: Service Manager: Remove ServiceContext* arg from Service::OnStart()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/service_manager/tests/lifecycle/app_client.h

Issue 2487573002: Service Manager: Remove ServiceContext* arg from Service::OnStart() (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/service_manager/tests/lifecycle/app_client.h

diff --git a/services/service_manager/tests/lifecycle/app_client.h b/services/service_manager/tests/lifecycle/app_client.h

index 83d1848b8ac40a59256e5af575abf0da226eea07..2c31a3fc22c8a9704507fdb5ada87255c472f8be 100644

--- a/services/service_manager/tests/lifecycle/app_client.h

+++ b/services/service_manager/tests/lifecycle/app_client.h

@@ -28,8 +28,7 @@ class AppClient : public Service,

void set_runner(ServiceRunner* runner) { runner_ = runner; }

- // Serivce:

- void OnStart(ServiceContext* context) override;

+ // Service:

bool OnConnect(const ServiceInfo& remote_info,

InterfaceRegistry* registry) override;

bool OnStop() override;

@@ -49,7 +48,6 @@ class AppClient : public Service,

void BindingLost();

- ServiceContext* context_;

ServiceRunner* runner_ = nullptr;

mojo::BindingSet<mojom::LifecycleControl> bindings_;