Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: services/service_manager/tests/lifecycle/app_client.h

Issue 2487573002: Service Manager: Remove ServiceContext* arg from Service::OnStart() (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/tests/lifecycle/app_client.h
diff --git a/services/service_manager/tests/lifecycle/app_client.h b/services/service_manager/tests/lifecycle/app_client.h
index 83d1848b8ac40a59256e5af575abf0da226eea07..2c31a3fc22c8a9704507fdb5ada87255c472f8be 100644
--- a/services/service_manager/tests/lifecycle/app_client.h
+++ b/services/service_manager/tests/lifecycle/app_client.h
@@ -28,8 +28,7 @@ class AppClient : public Service,
void set_runner(ServiceRunner* runner) { runner_ = runner; }
- // Serivce:
- void OnStart(ServiceContext* context) override;
+ // Service:
bool OnConnect(const ServiceInfo& remote_info,
InterfaceRegistry* registry) override;
bool OnStop() override;
@@ -49,7 +48,6 @@ class AppClient : public Service,
void BindingLost();
- ServiceContext* context_;
ServiceRunner* runner_ = nullptr;
mojo::BindingSet<mojom::LifecycleControl> bindings_;
« no previous file with comments | « services/service_manager/tests/connect/connect_test_package.cc ('k') | services/service_manager/tests/lifecycle/app_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698