Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: media/mojo/services/media_service.cc

Issue 2487573002: Service Manager: Remove ServiceContext* arg from Service::OnStart() (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/mojo/services/media_service.h ('k') | services/device/device_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/mojo/services/media_service.h" 5 #include "media/mojo/services/media_service.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "media/base/media_log.h" 9 #include "media/base/media_log.h"
10 #include "media/mojo/services/interface_factory_impl.h" 10 #include "media/mojo/services/interface_factory_impl.h"
11 #include "media/mojo/services/mojo_media_client.h" 11 #include "media/mojo/services/mojo_media_client.h"
12 #include "mojo/public/cpp/bindings/strong_binding.h" 12 #include "mojo/public/cpp/bindings/strong_binding.h"
13 #include "services/service_manager/public/cpp/connection.h" 13 #include "services/service_manager/public/cpp/connection.h"
14 #include "services/service_manager/public/cpp/connector.h" 14 #include "services/service_manager/public/cpp/connector.h"
15 #include "services/service_manager/public/cpp/interface_registry.h" 15 #include "services/service_manager/public/cpp/interface_registry.h"
16 16
17 namespace media { 17 namespace media {
18 18
19 // TODO(xhwang): Hook up MediaLog when possible. 19 // TODO(xhwang): Hook up MediaLog when possible.
20 MediaService::MediaService(std::unique_ptr<MojoMediaClient> mojo_media_client) 20 MediaService::MediaService(std::unique_ptr<MojoMediaClient> mojo_media_client)
21 : mojo_media_client_(std::move(mojo_media_client)), 21 : mojo_media_client_(std::move(mojo_media_client)),
22 media_log_(new MediaLog()) { 22 media_log_(new MediaLog()) {
23 DCHECK(mojo_media_client_); 23 DCHECK(mojo_media_client_);
24 } 24 }
25 25
26 MediaService::~MediaService() {} 26 MediaService::~MediaService() {}
27 27
28 void MediaService::OnStart(service_manager::ServiceContext* context) { 28 void MediaService::OnStart() {
29 ref_factory_.reset(new service_manager::ServiceContextRefFactory( 29 ref_factory_.reset(new service_manager::ServiceContextRefFactory(
30 base::Bind(&service_manager::ServiceContext::RequestQuit, 30 base::Bind(&service_manager::ServiceContext::RequestQuit,
31 base::Unretained(context)))); 31 base::Unretained(context()))));
32 mojo_media_client_->Initialize(); 32 mojo_media_client_->Initialize();
33 } 33 }
34 34
35 bool MediaService::OnConnect(const service_manager::ServiceInfo& remote_info, 35 bool MediaService::OnConnect(const service_manager::ServiceInfo& remote_info,
36 service_manager::InterfaceRegistry* registry) { 36 service_manager::InterfaceRegistry* registry) {
37 registry->AddInterface<mojom::MediaService>(this); 37 registry->AddInterface<mojom::MediaService>(this);
38 return true; 38 return true;
39 } 39 }
40 40
41 bool MediaService::OnStop() { 41 bool MediaService::OnStop() {
(...skipping 14 matching lines...) Expand all
56 return; 56 return;
57 57
58 mojo::MakeStrongBinding( 58 mojo::MakeStrongBinding(
59 base::MakeUnique<InterfaceFactoryImpl>( 59 base::MakeUnique<InterfaceFactoryImpl>(
60 std::move(remote_interfaces), media_log_, ref_factory_->CreateRef(), 60 std::move(remote_interfaces), media_log_, ref_factory_->CreateRef(),
61 mojo_media_client_.get()), 61 mojo_media_client_.get()),
62 std::move(request)); 62 std::move(request));
63 } 63 }
64 64
65 } // namespace media 65 } // namespace media
OLDNEW
« no previous file with comments | « media/mojo/services/media_service.h ('k') | services/device/device_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698