IFWL method and param cleanup

IFWL method and param cleanup

Cleaning up virtual methods, unused methods, and visibility.

Committed: https://pdfium.googlesource.com/pdfium/+/522c3d414e26a8a6b14407d664cee38fa3f52c07

[dsinclair, 2016-11-09 22:17:56]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-09 22:17:57]

PTAL.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.cpp
File xfa/fwl/core/ifwl_edit.cpp (left):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.cpp#...
xfa/fwl/core/ifwl_edit.cpp:205: int32_t nWordStart = GetWordAtPoint(pointf,
nWordCount);
nWordCount is always 0.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.cpp#...
xfa/fwl/core/ifwl_edit.cpp:241: if (nWordCount < 1) {
nWordCount is always 0

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.cpp#...
xfa/fwl/core/ifwl_edit.cpp:493: FWL_Error IFWL_Edit::DoClipboard(int32_t iCmd) {
This did nothing so removed.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.h
File xfa/fwl/core/ifwl_edit.h (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.h#ne...
xfa/fwl/core/ifwl_edit.h:215: CFDE_TxtEdtEngine m_EdtEngine;
This was being created in the constructor and was never changed and we had a lot
of logic around if it existed. So, I made it always exist.

[npm, 2016-11-09 23:41:26]

I haven't finished but it's dinner time now :)

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:402: return true;
Nit: make these three void as well.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_datetimep...
File xfa/fwl/core/ifwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:272: return true;
Ditto

[dsinclair, 2016-11-10 01:15:29]

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:402: return true;
On 2016/11/09 23:41:26, npm wrote:
> Nit: make these three void as well.

Will do that when I do the rest of the ifwl_combobox.h file. This was just
needed due to the changes to IFWL_Edit.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_datetimep...
File xfa/fwl/core/ifwl_datetimepicker.cpp (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:272: return true;
On 2016/11/09 23:41:26, npm wrote:
> Ditto

Acknowledged.

[Tom Sepez, 2016-11-10 17:00:26]

lgtm

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/cfwl_edit.h
File xfa/fwl/core/cfwl_edit.h (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/cfwl_edit.h#ne...
xfa/fwl/core/cfwl_edit.h:25: void GetText(CFX_WideString& wsText, int32_t nStart
= 0, int32_t nCount = -1);
can the return type be CFX_WideString?  Returning these are cheap and the
callers will look nicer.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:291: } else if (m_pListBox) {
nit: else after return.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.h
File xfa/fwl/core/ifwl_edit.h (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.h#ne...
xfa/fwl/core/ifwl_edit.h:119: void GetText(CFX_WideString& wsText, int32_t
nStart = 0, int32_t nCount = -1);
ditto.

[dsinclair, 2016-11-10 17:22:39]

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/cfwl_edit.h
File xfa/fwl/core/cfwl_edit.h (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/cfwl_edit.h#ne...
xfa/fwl/core/cfwl_edit.h:25: void GetText(CFX_WideString& wsText, int32_t nStart
= 0, int32_t nCount = -1);
On 2016/11/10 17:00:25, Tom Sepez wrote:
> can the return type be CFX_WideString?  Returning these are cheap and the
> callers will look nicer.


There are a lot of these that can be changed in the future. Leaving to a later
Cl.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:291: } else if (m_pListBox) {
On 2016/11/10 17:00:25, Tom Sepez wrote:
> nit: else after return.

Will get in a formatting followup.

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.h
File xfa/fwl/core/ifwl_edit.h (right):

https://codereview.chromium.org/2491103002/diff/1/xfa/fwl/core/ifwl_edit.h#ne...
xfa/fwl/core/ifwl_edit.h:119: void GetText(CFX_WideString& wsText, int32_t
nStart = 0, int32_t nCount = -1);
On 2016/11/10 17:00:26, Tom Sepez wrote:
> ditto.

Acknowledged.

[dsinclair, 2016-11-10 21:18:20]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-10 21:18:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2491103002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-11-10 21:18:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 22:01:23]

Description was changed from

==========
IFWL method and param cleanup

Cleaning up virtual methods, unused methods, and visibility.
==========

to

==========
IFWL method and param cleanup

Cleaning up virtual methods, unused methods, and visibility.

Committed:
https://pdfium.googlesource.com/pdfium/+/522c3d414e26a8a6b14407d664cee38fa3f5...
==========

[commit-bot: I haz the power, 2016-11-10 22:01:24]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/522c3d414e26a8a6b14407d664cee38fa3f5...