Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: xfa/fwl/core/cfwl_listbox.h

Issue 2486333004: Remove IFWL methods proxied from CFWL classes (Closed)
Patch Set: Rebase to master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_listbox.cpp » ('j') | xfa/fwl/core/cfwl_listbox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/core/cfwl_listbox.h
diff --git a/xfa/fwl/core/cfwl_listbox.h b/xfa/fwl/core/cfwl_listbox.h
index ff24e5a30832012ea2ed8930bd300dbfbe5dd041..901f77e894b3c5043d4bc5dc5500bae167e32b3c 100644
--- a/xfa/fwl/core/cfwl_listbox.h
+++ b/xfa/fwl/core/cfwl_listbox.h
@@ -22,28 +22,6 @@ class CFWL_ListBox : public CFWL_Widget, public IFWL_ListBoxDP {
void Initialize();
- FWL_Error AddDIBitmap(CFX_DIBitmap* pDIB, CFWL_ListItem* pItem);
- CFWL_ListItem* AddString(const CFX_WideStringC& wsAdd, bool bSelect = false);
- bool DeleteString(CFWL_ListItem* pItem);
- void DeleteAll();
- int32_t CountSelItems();
- CFWL_ListItem* GetSelItem(int32_t nIndexSel);
- int32_t GetSelIndex(int32_t nIndex);
- void SetSelItem(CFWL_ListItem* pItem, bool bSelect = true);
- void GetItemText(CFWL_ListItem* pItem, CFX_WideString& wsText);
- void GetScrollPos(FX_FLOAT& fPos, bool bVert = true);
- FWL_Error SetItemHeight(FX_FLOAT fItemHeight);
- CFWL_ListItem* GetFocusItem();
- FWL_Error SetFocusItem(CFWL_ListItem* pItem);
- int32_t CountItems();
- CFWL_ListItem* GetItem(int32_t nIndex);
- FWL_Error SetItemString(CFWL_ListItem* pItem, const CFX_WideStringC& wsText);
- FWL_Error GetItemString(CFWL_ListItem* pItem, CFX_WideString& wsText);
- FWL_Error SetItemData(CFWL_ListItem* pItem, void* pData);
- void* GetItemData(CFWL_ListItem* pItem);
- CFWL_ListItem* GetItemAtPoint(FX_FLOAT fx, FX_FLOAT fy);
- uint32_t GetItemStates(CFWL_ListItem* pItem);
-
// IFWL_DataProvider:
FWL_Error GetCaption(IFWL_Widget* pWidget,
CFX_WideString& wsCaption) override;
@@ -87,10 +65,26 @@ class CFWL_ListBox : public CFWL_Widget, public IFWL_ListBoxDP {
CFWL_ListItem* pItem,
uint32_t dwCheckState) override;
+ CFWL_ListItem* AddString(const CFX_WideStringC& wsAdd, bool bSelect = false);
npm 2016/11/10 19:12:07 Just curious, why are we moving these methods down
+ bool DeleteString(CFWL_ListItem* pItem);
+ void DeleteAll();
+
+ int32_t CountSelItems();
+
+ void SetSelItem(CFWL_ListItem* pItem, bool bSelect = true);
+ CFWL_ListItem* GetSelItem(int32_t nIndexSel);
+ int32_t GetSelIndex(int32_t nIndex);
+
+ void GetScrollPos(FX_FLOAT& fPos, bool bVert = true);
+
+ CFWL_ListItem* GetItem(int32_t nIndex);
+ void GetItemText(CFWL_ListItem* pItem, CFX_WideString& wsText);
+ uint32_t GetItemStates(CFWL_ListItem* pItem);
+
private:
+ int32_t CountItems();
+
std::vector<std::unique_ptr<CFWL_ListItem>> m_ItemArray;
- CFX_WideString m_wsData;
- FX_FLOAT m_fItemHeight;
};
#endif // XFA_FWL_CORE_CFWL_LISTBOX_H_
« no previous file with comments | « no previous file | xfa/fwl/core/cfwl_listbox.cpp » ('j') | xfa/fwl/core/cfwl_listbox.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698