Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2485873004:
[ImageResource 1b] Change SVGFEImageElement from ResourceClient to ImageResourceObserver (Closed)
DescriptionChange SVGFEImageElement from ResourceClient to ImageResourceObserver
This CL is a part of moving ResourceClient subclasses used for ImageResource
to ImageResourceObserver, in order to split ImageResource into Image-part and
Resource-part.
BUG=667641
Committed: https://crrev.com/a0a7ada7f1270cbacd19827816ff312c6fa9f685
Cr-Commit-Position: refs/heads/master@{#435274}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #Patch Set 7 : Rebase #Patch Set 8 : Rebase #Patch Set 9 : Rebase #Patch Set 10 : Rebase #Patch Set 11 : Rebase #
Total comments: 2
Patch Set 12 : Rebase #Patch Set 13 : Rebase #Patch Set 14 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 69 (59 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver BUG= ========== to ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver BUG= ========== to ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver BUG=667641 ==========
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
hiroshige@chromium.org changed reviewers: + yhirano@chromium.org
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver BUG=667641 ========== to ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 ==========
PTAL.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2485873004/diff/200001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/svg/SVGFEImageElement.h (right): https://codereview.chromium.org/2485873004/diff/200001/third_party/WebKit/Sou... third_party/WebKit/Source/core/svg/SVGFEImageElement.h:27: #include "core/fetch/ResourceClient.h" Not needed?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
+kouhei, PTAL as core/ OWNER.
hiroshige@chromium.org changed reviewers: + kouhei@chromium.org
+kouhei, PTAL as core/ OWNER.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2485873004/diff/200001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/svg/SVGFEImageElement.h (right): https://codereview.chromium.org/2485873004/diff/200001/third_party/WebKit/Sou... third_party/WebKit/Source/core/svg/SVGFEImageElement.h:27: #include "core/fetch/ResourceClient.h" On 2016/11/29 08:26:31, yhirano wrote: > Not needed? Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kouhei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org Link to the patchset: https://codereview.chromium.org/2485873004/#ps240001 (title: "Rebase")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2486073004 Patch 180001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org, kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/2485873004/#ps260001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 260001, "attempt_start_ts": 1480521498361850,
"parent_rev": "c3fafed3c07fc244a46a9db2351adc0b2de7840f", "commit_rev":
"4babd412add567ba0d19accb33eb6bacc1ba8061"}
Message was sent while issue was closed.
Description was changed from ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 ========== to ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 ==========
Message was sent while issue was closed.
Committed patchset #14 (id:260001)
Message was sent while issue was closed.
Description was changed from ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 ========== to ========== Change SVGFEImageElement from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 Committed: https://crrev.com/a0a7ada7f1270cbacd19827816ff312c6fa9f685 Cr-Commit-Position: refs/heads/master@{#435274} ==========
Message was sent while issue was closed.
Patchset 14 (id:??) landed as https://crrev.com/a0a7ada7f1270cbacd19827816ff312c6fa9f685 Cr-Commit-Position: refs/heads/master@{#435274} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
