Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2486073004: [ImageResource 1a] Change StyleFetchedImage from ResourceClient to ImageResourceObserver (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change StyleFetchedImage from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 Committed: https://crrev.com/37e0c8e928dfad9c455b5f2145a5e3e25e1350ca Cr-Commit-Position: refs/heads/master@{#435269}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Total comments: 2

Patch Set 9 : Rebase #

Patch Set 10 : Rebase #

Patch Set 11 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 2 4 chunks +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 62 (53 generated)
hiroshige
PTAL.
4 years ago (2016-11-28 06:24:09 UTC) #33
yhirano
lgtm https://codereview.chromium.org/2486073004/diff/140001/third_party/WebKit/Source/core/style/StyleFetchedImage.h File third_party/WebKit/Source/core/style/StyleFetchedImage.h (right): https://codereview.chromium.org/2486073004/diff/140001/third_party/WebKit/Source/core/style/StyleFetchedImage.h#newcode28 third_party/WebKit/Source/core/style/StyleFetchedImage.h:28: #include "core/fetch/ResourceClient.h" Not needed?
4 years ago (2016-11-29 08:26:59 UTC) #36
hiroshige
+kouhei, PTAL as core/ OWNER.
4 years ago (2016-11-29 09:13:46 UTC) #40
hiroshige
https://codereview.chromium.org/2486073004/diff/140001/third_party/WebKit/Source/core/style/StyleFetchedImage.h File third_party/WebKit/Source/core/style/StyleFetchedImage.h (right): https://codereview.chromium.org/2486073004/diff/140001/third_party/WebKit/Source/core/style/StyleFetchedImage.h#newcode28 third_party/WebKit/Source/core/style/StyleFetchedImage.h:28: #include "core/fetch/ResourceClient.h" On 2016/11/29 08:26:59, yhirano wrote: > Not ...
4 years ago (2016-11-29 09:18:01 UTC) #43
kouhei (in TOK)
lgtm
4 years ago (2016-11-29 09:18:16 UTC) #44
commit-bot: I haz the power
This CL has an open dependency (Issue 2468883003 Patch 220001). Please resolve the dependency and ...
4 years ago (2016-11-30 01:40:23 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486073004/200001
4 years ago (2016-11-30 14:12:01 UTC) #57
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years ago (2016-11-30 15:52:30 UTC) #60
commit-bot: I haz the power
4 years ago (2016-11-30 15:55:50 UTC) #62
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/37e0c8e928dfad9c455b5f2145a5e3e25e1350ca
Cr-Commit-Position: refs/heads/master@{#435269}

Powered by Google App Engine
This is Rietveld 408576698