Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

Issue 2485873004: [ImageResource 1b] Change SVGFEImageElement from ResourceClient to ImageResourceObserver (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFEImageElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2010 Dirk Schulze <krit@webkit.org> 4 * Copyright (C) 2010 Dirk Schulze <krit@webkit.org>
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 26 matching lines...) Expand all
37 m_preserveAspectRatio(SVGAnimatedPreserveAspectRatio::create( 37 m_preserveAspectRatio(SVGAnimatedPreserveAspectRatio::create(
38 this, 38 this,
39 SVGNames::preserveAspectRatioAttr)) { 39 SVGNames::preserveAspectRatioAttr)) {
40 addToPropertyMap(m_preserveAspectRatio); 40 addToPropertyMap(m_preserveAspectRatio);
41 } 41 }
42 42
43 DEFINE_NODE_FACTORY(SVGFEImageElement) 43 DEFINE_NODE_FACTORY(SVGFEImageElement)
44 44
45 SVGFEImageElement::~SVGFEImageElement() { 45 SVGFEImageElement::~SVGFEImageElement() {
46 if (m_cachedImage) { 46 if (m_cachedImage) {
47 m_cachedImage->removeClient(this); 47 m_cachedImage->removeObserver(this);
48 m_cachedImage = nullptr; 48 m_cachedImage = nullptr;
49 } 49 }
50 } 50 }
51 51
52 DEFINE_TRACE(SVGFEImageElement) { 52 DEFINE_TRACE(SVGFEImageElement) {
53 visitor->trace(m_preserveAspectRatio); 53 visitor->trace(m_preserveAspectRatio);
54 visitor->trace(m_cachedImage); 54 visitor->trace(m_cachedImage);
55 SVGFilterPrimitiveStandardAttributes::trace(visitor); 55 SVGFilterPrimitiveStandardAttributes::trace(visitor);
56 SVGURIReference::trace(visitor); 56 SVGURIReference::trace(visitor);
57 ResourceClient::trace(visitor);
58 } 57 }
59 58
60 bool SVGFEImageElement::currentFrameHasSingleSecurityOrigin() const { 59 bool SVGFEImageElement::currentFrameHasSingleSecurityOrigin() const {
61 if (m_cachedImage && m_cachedImage->getImage()) 60 if (m_cachedImage && m_cachedImage->getImage())
62 return m_cachedImage->getImage()->currentFrameHasSingleSecurityOrigin(); 61 return m_cachedImage->getImage()->currentFrameHasSingleSecurityOrigin();
63 62
64 return true; 63 return true;
65 } 64 }
66 65
67 void SVGFEImageElement::clearResourceReferences() { 66 void SVGFEImageElement::clearResourceReferences() {
68 if (m_cachedImage) { 67 if (m_cachedImage) {
69 m_cachedImage->removeClient(this); 68 m_cachedImage->removeObserver(this);
70 m_cachedImage = nullptr; 69 m_cachedImage = nullptr;
71 } 70 }
72 71
73 removeAllOutgoingReferences(); 72 removeAllOutgoingReferences();
74 } 73 }
75 74
76 void SVGFEImageElement::fetchImageResource() { 75 void SVGFEImageElement::fetchImageResource() {
77 FetchRequest request( 76 FetchRequest request(
78 ResourceRequest(ownerDocument()->completeURL(hrefString())), localName()); 77 ResourceRequest(ownerDocument()->completeURL(hrefString())), localName());
79 m_cachedImage = ImageResource::fetch(request, document().fetcher()); 78 m_cachedImage = ImageResource::fetch(request, document().fetcher());
80 79
81 if (m_cachedImage) 80 if (m_cachedImage)
82 m_cachedImage->addClient(this); 81 m_cachedImage->addObserver(this);
83 } 82 }
84 83
85 void SVGFEImageElement::buildPendingResource() { 84 void SVGFEImageElement::buildPendingResource() {
86 clearResourceReferences(); 85 clearResourceReferences();
87 if (!isConnected()) 86 if (!isConnected())
88 return; 87 return;
89 88
90 AtomicString id; 89 AtomicString id;
91 Element* target = SVGURIReference::targetElementFromIRIString( 90 Element* target = SVGURIReference::targetElementFromIRIString(
92 hrefString(), treeScope(), &id); 91 hrefString(), treeScope(), &id);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 buildPendingResource(); 128 buildPendingResource();
130 return InsertionDone; 129 return InsertionDone;
131 } 130 }
132 131
133 void SVGFEImageElement::removedFrom(ContainerNode* rootParent) { 132 void SVGFEImageElement::removedFrom(ContainerNode* rootParent) {
134 SVGFilterPrimitiveStandardAttributes::removedFrom(rootParent); 133 SVGFilterPrimitiveStandardAttributes::removedFrom(rootParent);
135 if (rootParent->isConnected()) 134 if (rootParent->isConnected())
136 clearResourceReferences(); 135 clearResourceReferences();
137 } 136 }
138 137
139 void SVGFEImageElement::notifyFinished(Resource*) { 138 void SVGFEImageElement::imageNotifyFinished(ImageResource*) {
140 if (!isConnected()) 139 if (!isConnected())
141 return; 140 return;
142 141
143 Element* parent = parentElement(); 142 Element* parent = parentElement();
144 if (!parent || !isSVGFilterElement(parent) || !parent->layoutObject()) 143 if (!parent || !isSVGFilterElement(parent) || !parent->layoutObject())
145 return; 144 return;
146 145
147 if (LayoutObject* layoutObject = this->layoutObject()) 146 if (LayoutObject* layoutObject = this->layoutObject())
148 markForLayoutAndParentResourceInvalidation(layoutObject); 147 markForLayoutAndParentResourceInvalidation(layoutObject);
149 } 148 }
150 149
151 FilterEffect* SVGFEImageElement::build(SVGFilterBuilder*, Filter* filter) { 150 FilterEffect* SVGFEImageElement::build(SVGFilterBuilder*, Filter* filter) {
152 if (m_cachedImage) { 151 if (m_cachedImage) {
153 // Don't use the broken image icon on image loading errors. 152 // Don't use the broken image icon on image loading errors.
154 RefPtr<Image> image = 153 RefPtr<Image> image =
155 m_cachedImage->errorOccurred() ? nullptr : m_cachedImage->getImage(); 154 m_cachedImage->errorOccurred() ? nullptr : m_cachedImage->getImage();
156 return FEImage::createWithImage(filter, image, 155 return FEImage::createWithImage(filter, image,
157 m_preserveAspectRatio->currentValue()); 156 m_preserveAspectRatio->currentValue());
158 } 157 }
159 158
160 return FEImage::createWithIRIReference(filter, treeScope(), hrefString(), 159 return FEImage::createWithIRIReference(filter, treeScope(), hrefString(),
161 m_preserveAspectRatio->currentValue()); 160 m_preserveAspectRatio->currentValue());
162 } 161 }
163 162
164 } // namespace blink 163 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFEImageElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698