|
|
Chromium Code Reviews
DescriptionChange StyleFetchedImageSet from ResourceClient to ImageResourceObserver
This CL is a part of moving ResourceClient subclasses used for ImageResource
to ImageResourceObserver, in order to split ImageResource into Image-part and
Resource-part.
BUG=667641
Committed: https://crrev.com/072105722f8a1095345faaa749c296e1bce19c15
Cr-Commit-Position: refs/heads/master@{#435339}
Patch Set 1 #Patch Set 2 : build fix #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #Patch Set 7 : Rebase #Patch Set 8 : Rebase #Patch Set 9 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 52 (44 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver BUG=667641 ========== to ========== Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver BUG=667641 ==========
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
hiroshige@chromium.org changed reviewers: + yhirano@chromium.org
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver BUG=667641 ========== to ========== Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 ==========
PTAL.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hiroshige@chromium.org changed reviewers: + kouhei@chromium.org
+kouhei, PTAL as core/ OWNER.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kouhei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org Link to the patchset: https://codereview.chromium.org/2521823003/#ps140001 (title: "Rebase")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2485873004 Patch 240001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org, kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/2521823003/#ps160001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 160001, "attempt_start_ts": 1480525588227190,
"parent_rev": "f595fc24cdb89da0a0a2166195d2fd6ca4876ee9", "commit_rev":
"02ee7ba50d44693ab9c8f1cf701b936aeaa88f92"}
Message was sent while issue was closed.
Description was changed from ========== Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 ========== to ========== Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 ==========
Message was sent while issue was closed.
Committed patchset #9 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 ========== to ========== Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 Committed: https://crrev.com/072105722f8a1095345faaa749c296e1bce19c15 Cr-Commit-Position: refs/heads/master@{#435339} ==========
Message was sent while issue was closed.
Patchset 9 (id:??) landed as https://crrev.com/072105722f8a1095345faaa749c296e1bce19c15 Cr-Commit-Position: refs/heads/master@{#435339} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
