Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2521823003: [ImageResource 1c] Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change StyleFetchedImageSet from ResourceClient to ImageResourceObserver This CL is a part of moving ResourceClient subclasses used for ImageResource to ImageResourceObserver, in order to split ImageResource into Image-part and Resource-part. BUG=667641 Committed: https://crrev.com/072105722f8a1095345faaa749c296e1bce19c15 Cr-Commit-Position: refs/heads/master@{#435339}

Patch Set 1 #

Patch Set 2 : build fix #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 52 (44 generated)
hiroshige
PTAL.
4 years ago (2016-11-28 06:24:18 UTC) #24
yhirano
lgtm
4 years ago (2016-11-29 08:27:35 UTC) #27
hiroshige
+kouhei, PTAL as core/ OWNER.
4 years ago (2016-11-29 09:13:05 UTC) #31
kouhei (in TOK)
lgtm
4 years ago (2016-11-29 09:20:41 UTC) #34
commit-bot: I haz the power
This CL has an open dependency (Issue 2485873004 Patch 240001). Please resolve the dependency and ...
4 years ago (2016-11-30 01:40:25 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521823003/160001
4 years ago (2016-11-30 17:06:47 UTC) #47
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years ago (2016-11-30 18:21:20 UTC) #50
commit-bot: I haz the power
4 years ago (2016-11-30 18:28:00 UTC) #52
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/072105722f8a1095345faaa749c296e1bce19c15
Cr-Commit-Position: refs/heads/master@{#435339}

Powered by Google App Engine
This is Rietveld 408576698