Migrate more tests to ScopedFeatureList.

Migrate more tests to ScopedFeatureList.

ScopedFeatureList ensures that the global FeatureList
instance is restored to the original state at the end
of the scope and results in less code.

BUG=620435
TBR=brettw@chromium.org

Committed: https://crrev.com/b1db826c74369f712111099190ae6bc6311ec9e7
Cr-Commit-Position: refs/heads/master@{#430560}

[Alexei Svitkine (slow), 2016-11-07 07:52:03]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 07:52:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 07:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 07:55:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2016-11-07 15:26:08]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 15:26:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 15:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 15:50:15]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Alexei Svitkine (slow), 2016-11-07 16:16:53]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 16:17:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 16:28:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 16:28:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Alexei Svitkine (slow), 2016-11-07 17:27:36]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 17:27:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 17:50:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:50:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2016-11-07 18:05:38]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 18:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-11-07 18:17:27]

Patchset #2 (id:20001) has been deleted

[Alexei Svitkine (slow), 2016-11-07 18:17:35]

Patchset #2 (id:40001) has been deleted

[Alexei Svitkine (slow), 2016-11-07 18:17:41]

Patchset #2 (id:60001) has been deleted

[Alexei Svitkine (slow), 2016-11-07 18:17:56]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-11-07 18:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 18:40:13]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Alexei Svitkine (slow), 2016-11-07 20:51:01]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 20:51:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-11-07 20:53:31]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[Alexei Svitkine (slow), 2016-11-07 20:53:39]

Patchset #2 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-11-07 20:53:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:28:19]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Alexei Svitkine (slow), 2016-11-07 22:42:46]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 22:43:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2016-11-07 23:23:40]

Patchset #2 (id:120001) has been deleted

[Alexei Svitkine (slow), 2016-11-07 23:23:50]

Patchset #1 (id:80001) has been deleted

[Alexei Svitkine (slow), 2016-11-07 23:25:27]

asvitkine@chromium.org changed reviewers:
+ isherman@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 23:40:29]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Alexei Svitkine (slow), 2016-11-07 23:45:15]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 23:46:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2016-11-08 00:20:00]

LGTM, thanks.

https://codereview.chromium.org/2484613002/diff/160001/base/feature_list.h
File base/feature_list.h (right):

https://codereview.chromium.org/2484613002/diff/160001/base/feature_list.h#ne...
base/feature_list.h:167: // a look at using base/test/scoped_feature_list.h
instead.
Maybe we should remove ClearInstanceForTesting() from the public API, to better
discourage tests from using SetInstance()?  I think we made
ClearInstanceForTesting() public prior to implementing a scoped feature list for
tests.

[commit-bot: I haz the power, 2016-11-08 00:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 00:40:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2016-11-08 01:48:52]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 01:49:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 04:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 04:36:50]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-11-08 08:03:58]

https://codereview.chromium.org/2484613002/diff/160001/base/feature_list.h
File base/feature_list.h (right):

https://codereview.chromium.org/2484613002/diff/160001/base/feature_list.h#ne...
base/feature_list.h:167: // a look at using base/test/scoped_feature_list.h
instead.
On 2016/11/08 00:20:00, Ilya Sherman wrote:
> Maybe we should remove ClearInstanceForTesting() from the public API, to
better
> discourage tests from using SetInstance()?  I think we made
> ClearInstanceForTesting() public prior to implementing a scoped feature list
for
> tests.

It's still being used from a few places - such as test harness runners and
ScopedFeatureList itself, so we can't remove it for now unless we find
replacements for those.

[Alexei Svitkine (slow), 2016-11-08 08:04:34]

Description was changed from

==========
Migrate more tests to ScopedFeatureList.

ScopedFeatureList ensures that the global FeatureList
instance is restored to the original state at the end
of the scope and results in less code.

BUG=620435
==========

to

==========
Migrate more tests to ScopedFeatureList.

ScopedFeatureList ensures that the global FeatureList
instance is restored to the original state at the end
of the scope and results in less code.

BUG=620435
TBR=brettw@chromium.org
==========

[Alexei Svitkine (slow), 2016-11-08 08:04:34]

asvitkine@chromium.org changed reviewers:
+ brettw@chromium.org

[Alexei Svitkine (slow), 2016-11-08 08:05:09]

+TBR=brettw@chromium.org for OWNERs of downstream changes of base/feature_list.h

[Alexei Svitkine (slow), 2016-11-08 08:05:16]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-11-08 08:05:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2484613002/#ps180001
(title: "Fix build")

[commit-bot: I haz the power, 2016-11-08 08:05:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 08:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 08:12:13]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexei Svitkine (slow), 2016-11-08 08:19:02]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-11-08 08:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2484613002/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-08 08:19:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 09:48:48]

Description was changed from

==========
Migrate more tests to ScopedFeatureList.

ScopedFeatureList ensures that the global FeatureList
instance is restored to the original state at the end
of the scope and results in less code.

BUG=620435
TBR=brettw@chromium.org
==========

to

==========
Migrate more tests to ScopedFeatureList.

ScopedFeatureList ensures that the global FeatureList
instance is restored to the original state at the end
of the scope and results in less code.

BUG=620435
TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-11-08 09:48:51]

Committed patchset #4 (id:200001)

[commit-bot: I haz the power, 2016-11-08 09:57:14]

Description was changed from

==========
Migrate more tests to ScopedFeatureList.

ScopedFeatureList ensures that the global FeatureList
instance is restored to the original state at the end
of the scope and results in less code.

BUG=620435
TBR=brettw@chromium.org
==========

to

==========
Migrate more tests to ScopedFeatureList.

ScopedFeatureList ensures that the global FeatureList
instance is restored to the original state at the end
of the scope and results in less code.

BUG=620435
TBR=brettw@chromium.org

Committed: https://crrev.com/b1db826c74369f712111099190ae6bc6311ec9e7
Cr-Commit-Position: refs/heads/master@{#430560}
==========

[commit-bot: I haz the power, 2016-11-08 09:57:16]

Patchset 4 (id:??) landed as
https://crrev.com/b1db826c74369f712111099190ae6bc6311ec9e7
Cr-Commit-Position: refs/heads/master@{#430560}