Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: content/browser/loader/reload_cache_control_browsertest.cc

Issue 2484613002: Migrate more tests to ScopedFeatureList. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/reload_cache_control_browsertest.cc
diff --git a/content/browser/loader/reload_cache_control_browsertest.cc b/content/browser/loader/reload_cache_control_browsertest.cc
index 362bff46039b635458504bd8deed9313d74df1b7..8999d37b1997a123f61b2b0a9ce72ad5832243b3 100644
--- a/content/browser/loader/reload_cache_control_browsertest.cc
+++ b/content/browser/loader/reload_cache_control_browsertest.cc
@@ -6,8 +6,8 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
-#include "base/feature_list.h"
#include "base/files/file_path.h"
+#include "base/test/scoped_feature_list.h"
#include "content/public/common/content_features.h"
#include "content/public/test/content_browser_test.h"
#include "content/public/test/content_browser_test_utils.h"
@@ -45,11 +45,8 @@ class ReloadCacheControlBrowserTest : public ContentBrowserTest {
void SetUpOnMainThread() override {
// TODO(toyoshim): Tests in this file depend on current reload behavior,
// and should be modified when we enable the new reload behavior.
- base::FeatureList::ClearInstanceForTesting();
- std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
- feature_list->InitializeFromCommandLine(
- std::string(), features::kNonValidatingReloadOnNormalReload.name);
- base::FeatureList::SetInstance(std::move(feature_list));
+ scoped_feature_list_.InitAndDisableFeature(
+ features::kNonValidatingReloadOnNormalReload);
SetUpTestServerOnMainThread();
}
@@ -80,6 +77,8 @@ class ReloadCacheControlBrowserTest : public ContentBrowserTest {
request_log_.push_back(log);
}
+ base::test::ScopedFeatureList scoped_feature_list_;
+
DISALLOW_COPY_AND_ASSIGN(ReloadCacheControlBrowserTest);
};
@@ -90,15 +89,14 @@ class ReloadCacheControlWithAnExperimentBrowserTest
~ReloadCacheControlWithAnExperimentBrowserTest() override = default;
void SetUpOnMainThread() override {
- base::FeatureList::ClearInstanceForTesting();
- std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
- feature_list->InitializeFromCommandLine(
- features::kNonValidatingReloadOnNormalReload.name, std::string());
- base::FeatureList::SetInstance(std::move(feature_list));
+ scoped_feature_list_.InitAndEnableFeature(
+ features::kNonValidatingReloadOnNormalReload);
SetUpTestServerOnMainThread();
}
+ base::test::ScopedFeatureList scoped_feature_list_;
+
DISALLOW_COPY_AND_ASSIGN(ReloadCacheControlWithAnExperimentBrowserTest);
};

Powered by Google App Engine
This is Rietveld 408576698