Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Side by Side Diff: chrome/browser/ui/webui/uber/uber_ui_browsertest.cc

Issue 2484613002: Migrate more tests to ScopedFeatureList. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/feature_list.h"
10 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/test/scoped_feature_list.h"
11 #include "chrome/browser/extensions/extension_service.h" 11 #include "chrome/browser/extensions/extension_service.h"
12 #include "chrome/browser/extensions/test_extension_system.h" 12 #include "chrome/browser/extensions/test_extension_system.h"
13 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/ui/browser.h" 14 #include "chrome/browser/ui/browser.h"
15 #include "chrome/browser/ui/tabs/tab_strip_model.h" 15 #include "chrome/browser/ui/tabs/tab_strip_model.h"
16 #include "chrome/browser/ui/webui/md_history_ui.h" 16 #include "chrome/browser/ui/webui/md_history_ui.h"
17 #include "chrome/common/chrome_features.h" 17 #include "chrome/common/chrome_features.h"
18 #include "chrome/common/chrome_switches.h" 18 #include "chrome/common/chrome_switches.h"
19 #include "chrome/common/url_constants.h" 19 #include "chrome/common/url_constants.h"
20 #include "chrome/test/base/ui_test_utils.h" 20 #include "chrome/test/base/ui_test_utils.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 ExtensionService* service = extensions::ExtensionSystem::Get( 81 ExtensionService* service = extensions::ExtensionSystem::Get(
82 browser()->profile())->extension_service(); 82 browser()->profile())->extension_service();
83 // Load extension. UberUI overrides history navigation. 83 // Load extension. UberUI overrides history navigation.
84 // In this test, injected script will be called instead. 84 // In this test, injected script will be called instead.
85 service->AddExtension(extension.get()); 85 service->AddExtension(extension.get());
86 86
87 EXPECT_TRUE(GetJsBool("overrideCalled")); 87 EXPECT_TRUE(GetJsBool("overrideCalled"));
88 } 88 }
89 89
90 IN_PROC_BROWSER_TEST_F(UberUIBrowserTest, EnableMdExtensionsHidesExtensions) { 90 IN_PROC_BROWSER_TEST_F(UberUIBrowserTest, EnableMdExtensionsHidesExtensions) {
91 std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList); 91 base::test::ScopedFeatureList scoped_feature_list;
92 feature_list->InitializeFromCommandLine( 92 scoped_feature_list.InitAndEnableFeature(features::kMaterialDesignExtensions);
93 features::kMaterialDesignExtensions.name, "");
94 base::FeatureList::ClearInstanceForTesting();
95 base::FeatureList::SetInstance(std::move(feature_list));
96 93
97 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIUberFrameURL)); 94 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIUberFrameURL));
98 SelectTab(); 95 SelectTab();
99 EXPECT_TRUE(GetJsBool("$('extensions').hidden")); 96 EXPECT_TRUE(GetJsBool("$('extensions').hidden"));
100 } 97 }
101 98
102 IN_PROC_BROWSER_TEST_F(UberUIBrowserTest, EnableMdHistoryHidesHistory) { 99 IN_PROC_BROWSER_TEST_F(UberUIBrowserTest, EnableMdHistoryHidesHistory) {
103 MdHistoryUI::SetEnabledForTesting(true); 100 MdHistoryUI::SetEnabledForTesting(true);
104 101
105 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIUberFrameURL)); 102 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIUberFrameURL));
106 SelectTab(); 103 SelectTab();
107 EXPECT_TRUE(GetJsBool("$('history').hidden")); 104 EXPECT_TRUE(GetJsBool("$('history').hidden"));
108 } 105 }
109 106
110 IN_PROC_BROWSER_TEST_F(UberUIBrowserTest, EnableMdSettingsHidesSettings) { 107 IN_PROC_BROWSER_TEST_F(UberUIBrowserTest, EnableMdSettingsHidesSettings) {
111 std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList); 108 base::test::ScopedFeatureList scoped_feature_list;
112 feature_list->InitializeFromCommandLine( 109 scoped_feature_list.InitAndEnableFeature(features::kMaterialDesignSettings);
113 features::kMaterialDesignSettings.name, "");
114 base::FeatureList::ClearInstanceForTesting();
115 base::FeatureList::SetInstance(std::move(feature_list));
116 110
117 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIUberFrameURL)); 111 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIUberFrameURL));
118 SelectTab(); 112 SelectTab();
119 EXPECT_TRUE(GetJsBool("$('settings').hidden && $('help').hidden")); 113 EXPECT_TRUE(GetJsBool("$('settings').hidden && $('help').hidden"));
120 } 114 }
121 115
122 IN_PROC_BROWSER_TEST_F(UberUIBrowserTest, 116 IN_PROC_BROWSER_TEST_F(UberUIBrowserTest,
123 EnableSettingsWindowHidesSettingsAndHelp) { 117 EnableSettingsWindowHidesSettingsAndHelp) {
124 base::CommandLine::ForCurrentProcess()->AppendSwitch( 118 base::CommandLine::ForCurrentProcess()->AppendSwitch(
125 ::switches::kEnableSettingsWindow); 119 ::switches::kEnableSettingsWindow);
126 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIUberFrameURL)); 120 ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIUberFrameURL));
127 SelectTab(); 121 SelectTab();
128 EXPECT_TRUE(GetJsBool("$('settings').hidden && $('help').hidden")); 122 EXPECT_TRUE(GetJsBool("$('settings').hidden && $('help').hidden"));
129 } 123 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698