Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: chrome/browser/safe_browsing/permission_reporter_unittest.cc

Issue 2484613002: Migrate more tests to ScopedFeatureList. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/permission_reporter.h" 5 #include "chrome/browser/safe_browsing/permission_reporter.h"
6 6
7 #include "base/feature_list.h"
8 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
9 #include "base/metrics/field_trial.h" 8 #include "base/metrics/field_trial.h"
9 #include "base/test/scoped_feature_list.h"
10 #include "base/test/simple_test_clock.h" 10 #include "base/test/simple_test_clock.h"
11 #include "base/time/time.h" 11 #include "base/time/time.h"
12 #include "chrome/browser/permissions/permission_request.h" 12 #include "chrome/browser/permissions/permission_request.h"
13 #include "chrome/browser/safe_browsing/mock_permission_report_sender.h" 13 #include "chrome/browser/safe_browsing/mock_permission_report_sender.h"
14 #include "chrome/common/safe_browsing/permission_report.pb.h" 14 #include "chrome/common/safe_browsing/permission_report.pb.h"
15 #include "components/variations/active_field_trials.h" 15 #include "components/variations/active_field_trials.h"
16 #include "content/public/browser/permission_type.h" 16 #include "content/public/browser/permission_type.h"
17 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
18 18
19 using content::PermissionType; 19 using content::PermissionType;
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 base::FieldTrial* trial_two = 136 base::FieldTrial* trial_two =
137 base::FieldTrialList::CreateFieldTrial(kDummyTrialTwo, kDummyGroupTwo); 137 base::FieldTrialList::CreateFieldTrial(kDummyTrialTwo, kDummyGroupTwo);
138 138
139 feature_list->RegisterFieldTrialOverride( 139 feature_list->RegisterFieldTrialOverride(
140 kFeatureOnByDefaultName, base::FeatureList::OVERRIDE_ENABLE_FEATURE, 140 kFeatureOnByDefaultName, base::FeatureList::OVERRIDE_ENABLE_FEATURE,
141 trial_one); 141 trial_one);
142 feature_list->RegisterFieldTrialOverride( 142 feature_list->RegisterFieldTrialOverride(
143 kFeatureOffByDefaultName, base::FeatureList::OVERRIDE_ENABLE_FEATURE, 143 kFeatureOffByDefaultName, base::FeatureList::OVERRIDE_ENABLE_FEATURE,
144 trial_two); 144 trial_two);
145 145
146 base::FeatureList::ClearInstanceForTesting(); 146 base::test::ScopedFeatureList scoped_feature_list;
147 base::FeatureList::SetInstance(std::move(feature_list)); 147 scoped_feature_list.InitWithFeatureList(std::move(feature_list));
148 148
149 // This is necessary to activate both field trials. 149 // This is necessary to activate both field trials.
150 base::FeatureList::IsEnabled(kFeatureOnByDefault); 150 base::FeatureList::IsEnabled(kFeatureOnByDefault);
151 base::FeatureList::IsEnabled(kFeatureOffByDefault); 151 base::FeatureList::IsEnabled(kFeatureOffByDefault);
152 152
153 EXPECT_TRUE(base::FieldTrialList::IsTrialActive(trial_one->trial_name())); 153 EXPECT_TRUE(base::FieldTrialList::IsTrialActive(trial_one->trial_name()));
154 EXPECT_TRUE(base::FieldTrialList::IsTrialActive(trial_two->trial_name())); 154 EXPECT_TRUE(base::FieldTrialList::IsTrialActive(trial_two->trial_name()));
155 155
156 permission_reporter_->SendReport(BuildDummyReportInfo()); 156 permission_reporter_->SendReport(BuildDummyReportInfo());
157 157
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 reports_to_send = 12; 210 reports_to_send = 12;
211 while (reports_to_send--) { 211 while (reports_to_send--) {
212 clock_->Advance(base::TimeDelta::FromSeconds(5)); 212 clock_->Advance(base::TimeDelta::FromSeconds(5));
213 permission_reporter_->SendReport(BuildDummyReportInfo()); 213 permission_reporter_->SendReport(BuildDummyReportInfo());
214 } 214 }
215 EXPECT_EQ(kMaximumReportsPerOriginPerPermissionPerMinute, 215 EXPECT_EQ(kMaximumReportsPerOriginPerPermissionPerMinute,
216 mock_report_sender_->GetAndResetNumberOfReportsSent()); 216 mock_report_sender_->GetAndResetNumberOfReportsSent());
217 } 217 }
218 218
219 } // namespace safe_browsing 219 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698