HTTP Bad: Split out UMA metrics for password vs credit card "Not secure" warnings

HTTP Bad: Split out UMA metrics for password vs credit card "Not secure" warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,
one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean
password/credit card flags in |security_info|.

BUG=663389
Committed: https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Committed: https://crrev.com/05079791166f38efb6b1bc5ccdc8d985d799863b
Cr-Original-Commit-Position: refs/heads/master@{#431481}
Cr-Commit-Position: refs/heads/master@{#431515}

[lshang, 2016-11-09 08:38:13]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 08:38:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-11-09 08:38:26]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings


change

BUG=
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings


change

BUG=663389
==========

[commit-bot: I haz the power, 2016-11-09 09:29:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 09:29:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lshang, 2016-11-09 10:00:16]

Patchset #1 (id:1) has been deleted

[lshang, 2016-11-09 10:00:23]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 10:00:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-11-09 10:00:59]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings


change

BUG=663389
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split out the "Not secure" omnibox warning UMA by whether a password or credit 
card (or both) triggered it.

BUG=663389
==========

[lshang, 2016-11-09 10:03:46]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split out the "Not secure" omnibox warning UMA by whether a password or credit 
card (or both) triggered it.

BUG=663389
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,

one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two 
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and 
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean

password/credit card flags in |security_info|.

BUG=663389
==========

[lshang, 2016-11-09 10:04:05]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,

one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two 
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and 
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean

password/credit card flags in |security_info|.

BUG=663389
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,

one for passwords and one for credit cards, and split out the 
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two 
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and 
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean

password/credit card flags in |security_info|.

BUG=663389
==========

[lshang, 2016-11-09 10:05:26]

lshang@chromium.org changed reviewers:
+ estark@chromium.org, isherman@chromium.org

[lshang, 2016-11-09 10:05:27]

+estark@ for security_state files and +isherman@ for changes in histograms.xml.

PTAL thanks!

[commit-bot: I haz the power, 2016-11-09 11:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:36:37]

Dry run: This issue passed the CQ dry run.

[estark, 2016-11-09 15:56:46]

Thank, Liu! This is looking great, just a few comments inline.

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
File chrome/browser/ssl/chrome_security_state_model_client.cc (right):

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client.cc:338:
!security_info.displayed_credit_card_field_on_http)
nit: now that the conditional spans two lines, can you please add curly braces
around the body?

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client.cc:368:
security_info.displayed_credit_card_field_on_http &&
Hmm. I think we ought to only record the histograms conditionally, like this:

if (security_info.displayed_credit_card_field_on_http) {
  UMA_HISTOGRAM_BOOLEAN("...CreditCard", warning_is_user_visible);
}
if (security_info.displayed_password_field_on_http) {
  UMA_HISTOGRAM_BOOLEAN("...Password", warning_is_user_visible);
}

That way a histogram value of false means "there was a password/credit card
field and we only logged a console message." As it is right now, with recording
the histogram unconditionally, a value of false could mean multiple things: it
could mean there was a password/cc field and we only logged a console message,
or it could mean there was no password/cc field.

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
File chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
(right):

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc:1344: 
Could you please add a section here at the end of this test that navigates to
title1.html and calls contents->OnCreditCardInputShownOnHttp() and waits for a
console message? Basically repeating lines 1327-1343 except navigating to
title1.html and setting a credit card instead of a password.

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
File chrome/browser/ssl/chrome_security_state_model_client_unittest.cc (right):

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:251:
security_info.displayed_credit_card_field_on_http = true;
Maybe you could call explanations.info_explanations.clear() here. (It's a little
confusing to see 2u on line 255 because normally |explanations| is empty when
GetSecurityStyle() is called.)

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:255:
EXPECT_EQ(2u, explanations.info_explanations.size());
Could you please add another section that one info explanation is added if
*both* the password and credit card fields are true? (I'd like to have a test
that we don't add two explanations if both fields are set.)

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:333: 
I think you can also use INSTANTIATE_TEST_CASE_P for unit tests. Could you use
that here so that each of these tests runs for both the password histogram and
the credit card histogram?

https://codereview.chromium.org/2483423002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2483423002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:56582: +<histogram
name="Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard"
isherman will tell you for sure, but I think the right way to remove the old one
is to leave it here and add an <obsolete> tag to it that explains why it's no
longer used. (Search for 'obsolete' in this file to see an example.)

[lshang, 2016-11-10 04:52:43]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 04:52:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-11-10 04:53:55]

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
File chrome/browser/ssl/chrome_security_state_model_client.cc (right):

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client.cc:338:
!security_info.displayed_credit_card_field_on_http)
On 2016/11/09 15:56:46, estark (slow thru Nov 18) wrote:
> nit: now that the conditional spans two lines, can you please add curly braces
> around the body?

Done.

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client.cc:368:
security_info.displayed_credit_card_field_on_http &&
On 2016/11/09 15:56:46, estark (slow thru Nov 18) wrote:
> Hmm. I think we ought to only record the histograms conditionally, like this:
> 
> if (security_info.displayed_credit_card_field_on_http) {
>   UMA_HISTOGRAM_BOOLEAN("...CreditCard", warning_is_user_visible);
> }
> if (security_info.displayed_password_field_on_http) {
>   UMA_HISTOGRAM_BOOLEAN("...Password", warning_is_user_visible);
> }
> 
> That way a histogram value of false means "there was a password/credit card
> field and we only logged a console message." As it is right now, with
recording
> the histogram unconditionally, a value of false could mean multiple things: it
> could mean there was a password/cc field and we only logged a console message,
> or it could mean there was no password/cc field.

Done.

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
File chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
(right):

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc:1344: 
On 2016/11/09 15:56:46, estark (slow thru Nov 18) wrote:
> Could you please add a section here at the end of this test that navigates to
> title1.html and calls contents->OnCreditCardInputShownOnHttp() and waits for a
> console message? Basically repeating lines 1327-1343 except navigating to
> title1.html and setting a credit card instead of a password.

Done.

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
File chrome/browser/ssl/chrome_security_state_model_client_unittest.cc (right):

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:251:
security_info.displayed_credit_card_field_on_http = true;
On 2016/11/09 15:56:46, estark (slow thru Nov 18) wrote:
> Maybe you could call explanations.info_explanations.clear() here. (It's a
little
> confusing to see 2u on line 255 because normally |explanations| is empty when
> GetSecurityStyle() is called.)

Done.

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:255:
EXPECT_EQ(2u, explanations.info_explanations.size());
On 2016/11/09 15:56:46, estark (slow thru Nov 18) wrote:
> Could you please add another section that one info explanation is added if
> *both* the password and credit card fields are true? (I'd like to have a test
> that we don't add two explanations if both fields are set.)

Done.

https://codereview.chromium.org/2483423002/diff/20001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:333: 
On 2016/11/09 15:56:46, estark (slow thru Nov 18) wrote:
> I think you can also use INSTANTIATE_TEST_CASE_P for unit tests. Could you use
> that here so that each of these tests runs for both the password histogram and
> the credit card histogram?

Done.

https://codereview.chromium.org/2483423002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2483423002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:56582: +<histogram
name="Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard"
On 2016/11/09 15:56:46, estark (slow thru Nov 18) wrote:
> isherman will tell you for sure, but I think the right way to remove the old
one
> is to leave it here and add an <obsolete> tag to it that explains why it's no
> longer used. (Search for 'obsolete' in this file to see an example.)

Done.

[estark, 2016-11-10 05:19:29]

lgtm, thanks!

https://codereview.chromium.org/2483423002/diff/40001/chrome/browser/ssl/chro...
File chrome/browser/ssl/chrome_security_state_model_client_unittest.cc (right):

https://codereview.chromium.org/2483423002/diff/40001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:256: // one
explanation added.
nit: added => is added

https://codereview.chromium.org/2483423002/diff/40001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:357: // credit
catd field.
nit: typo, catd => card

[lshang, 2016-11-10 05:33:52]

https://codereview.chromium.org/2483423002/diff/40001/chrome/browser/ssl/chro...
File chrome/browser/ssl/chrome_security_state_model_client_unittest.cc (right):

https://codereview.chromium.org/2483423002/diff/40001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:256: // one
explanation added.
On 2016/11/10 05:19:29, estark (slow thru Nov 18) wrote:
> nit: added => is added

Done.

https://codereview.chromium.org/2483423002/diff/40001/chrome/browser/ssl/chro...
chrome/browser/ssl/chrome_security_state_model_client_unittest.cc:357: // credit
catd field.
On 2016/11/10 05:19:29, estark (slow thru Nov 18) wrote:
> nit: typo, catd => card

Done. Also correct the indent.

[Ilya Sherman, 2016-11-10 06:13:51]

metrics lgtm

[lshang, 2016-11-10 22:54:29]

The CQ bit was checked by lshang@chromium.org

[lshang, 2016-11-10 22:54:30]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2483423002/#ps60001
(title: "minor change")

[commit-bot: I haz the power, 2016-11-10 22:55:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 22:58:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 22:58:56]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lshang, 2016-11-11 02:18:21]

The CQ bit was checked by lshang@chromium.org

[lshang, 2016-11-11 02:18:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2483423002/#ps80001
(title: "rebase to fix patch failure")

[commit-bot: I haz the power, 2016-11-11 02:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 03:16:25]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,

one for passwords and one for credit cards, and split out the 
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two 
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and 
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean

password/credit card flags in |security_info|.

BUG=663389
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,

one for passwords and one for credit cards, and split out the 
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two 
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and 
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean

password/credit card flags in |security_info|.

BUG=663389
==========

[commit-bot: I haz the power, 2016-11-11 03:16:27]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-11 03:35:55]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,

one for passwords and one for credit cards, and split out the 
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two 
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and 
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean

password/credit card flags in |security_info|.

BUG=663389
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,
one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean
password/credit card flags in |security_info|.

BUG=663389

Committed: https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Cr-Commit-Position: refs/heads/master@{#431481}
==========

[commit-bot: I haz the power, 2016-11-11 03:35:56]

Patchset 4 (id:??) landed as
https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Cr-Commit-Position: refs/heads/master@{#431481}

[findit-for-me, 2016-11-11 05:39:59]

FYI: Findit identified this CL at revision 431481 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[hiroshige, 2016-11-11 06:14:56]

On 2016/11/11 05:39:59, findit-for-me wrote:
> FYI: Findit identified this CL at revision 431481 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Going to revert this CL due to SystemTrayTest.NullDefaultViewIsNotRecorded
(ash_unittests) failure on Windows-7 (as findit mentioned in Comment #35).
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

[hiroshige, 2016-11-11 06:27:15]

On 2016/11/11 06:14:56, hiroshige wrote:
> On 2016/11/11 05:39:59, findit-for-me wrote:
> > FYI: Findit identified this CL at revision 431481 as the culprit for
> > failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Going to revert this CL due to SystemTrayTest.NullDefaultViewIsNotRecorded
> (ash_unittests) failure on Windows-7 (as findit mentioned in Comment #35).
>
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...

Created a revert CL manually (just because histograms.xml is too large to create
a revert CL by "Revert Patchset" button):
https://codereview.chromium.org/2494033002/

[hiroshige, 2016-11-11 07:24:51]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,
one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean
password/credit card flags in |security_info|.

BUG=663389

Committed: https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Cr-Commit-Position: refs/heads/master@{#431481}
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,
one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean
password/credit card flags in |security_info|.

BUG=663389

Committed: https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Cr-Commit-Position: refs/heads/master@{#431481}
==========

[hiroshige, 2016-11-11 07:24:59]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-11-11 07:25:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-11 07:25:34]

On 2016/11/11 06:27:15, hiroshige wrote:
> On 2016/11/11 06:14:56, hiroshige wrote:
> > On 2016/11/11 05:39:59, findit-for-me wrote:
> > > FYI: Findit identified this CL at revision 431481 as the culprit for
> > > failures in the build cycles as shown on:
> > >
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> > 
> > Going to revert this CL due to SystemTrayTest.NullDefaultViewIsNotRecorded
> > (ash_unittests) failure on Windows-7 (as findit mentioned in Comment #35).
> >
>
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)/builds/...
> 
> Created a revert CL manually (just because histograms.xml is too large to
create
> a revert CL by "Revert Patchset" button):
> https://codereview.chromium.org/2494033002/

Relanding this CL, as reverting this CL didn't resolve the test failure:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

[commit-bot: I haz the power, 2016-11-11 07:30:26]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,
one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean
password/credit card flags in |security_info|.

BUG=663389

Committed: https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Cr-Commit-Position: refs/heads/master@{#431481}
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,
one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean
password/credit card flags in |security_info|.

BUG=663389

Committed: https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Cr-Commit-Position: refs/heads/master@{#431481}
==========

[commit-bot: I haz the power, 2016-11-11 07:30:27]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-11 07:33:07]

Description was changed from

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,
one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean
password/credit card flags in |security_info|.

BUG=663389

Committed: https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Cr-Commit-Position: refs/heads/master@{#431481}
==========

to

==========
HTTP Bad: Split out UMA metrics for password vs credit card "Not secure"
warnings

Split SecurityInfo::displayed_private_user_input_data_on_http into two booleans,
one for passwords and one for credit cards, and split out the
Security.HTTPBad.UserWarnedAboutSensitiveInput histogram into two
histograms: Security.HTTPBad.UserWarnedAboutSensitiveInput.CreditCard and
Security.HTTPBad.UserWarnedAboutSensitiveInput.Password depending on the boolean
password/credit card flags in |security_info|.

BUG=663389

Committed: https://crrev.com/4805cebc1656e9f99905537db6b369bec581ac28
Committed: https://crrev.com/05079791166f38efb6b1bc5ccdc8d985d799863b
Cr-Original-Commit-Position: refs/heads/master@{#431481}
Cr-Commit-Position: refs/heads/master@{#431515}
==========

[commit-bot: I haz the power, 2016-11-11 07:33:09]

Patchset 4 (id:??) landed as
https://crrev.com/05079791166f38efb6b1bc5ccdc8d985d799863b
Cr-Commit-Position: refs/heads/master@{#431515}