Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: components/security_state/security_state_model.cc

Issue 2483423002: HTTP Bad: Split out UMA metrics for password vs credit card "Not secure" warnings (Closed)
Patch Set: rebase to fix patch failure Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/security_state_model.cc
diff --git a/components/security_state/security_state_model.cc b/components/security_state/security_state_model.cc
index 7ed1a53347d4e314bed110ed5b8ee1f46bd8e92a..6d4094e1bdea2ef067a584604a171cc3aa9af903 100644
--- a/components/security_state/security_state_model.cc
+++ b/components/security_state/security_state_model.cc
@@ -242,8 +242,9 @@ void SecurityInfoForRequest(
security_info->fails_malware_check =
visible_security_state.fails_malware_check;
- security_info->displayed_private_user_data_input_on_http =
- visible_security_state.displayed_password_field_on_http ||
+ security_info->displayed_password_field_on_http =
+ visible_security_state.displayed_password_field_on_http;
+ security_info->displayed_credit_card_field_on_http =
visible_security_state.displayed_credit_card_field_on_http;
security_info->security_level = GetSecurityLevelForRequest(
@@ -274,7 +275,8 @@ SecurityStateModel::SecurityInfo::SecurityInfo()
key_exchange_group(0),
obsolete_ssl_status(net::OBSOLETE_SSL_NONE),
pkp_bypassed(false),
- displayed_private_user_data_input_on_http(false) {}
+ displayed_password_field_on_http(false),
+ displayed_credit_card_field_on_http(false) {}
SecurityStateModel::SecurityInfo::~SecurityInfo() {}
« no previous file with comments | « components/security_state/security_state_model.h ('k') | components/security_state/security_state_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698