HTTP Bad: Split out UMA metrics for password vs credit card "Not secure" warnings

components/security_state/security_state_model_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/security_state/security_state_model.h"
 
 #include <stdint.h>
 
 #include "base/command_line.h"
 #include "base/test/histogram_tester.h"
@@ skipping 233 matching lines @@
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kMarkHttpAs,
       switches::kMarkHttpWithPasswordsOrCcWithChip);
   TestSecurityStateModelClient client;
   client.UseHttpUrl();
   SecurityStateModel model;
   model.SetClient(&client);
   client.set_displayed_password_field_on_http(true);
   SecurityStateModel::SecurityInfo security_info;
   model.GetSecurityInfo(&security_info);
-  EXPECT_TRUE(security_info.displayed_private_user_data_input_on_http);
+  EXPECT_TRUE(security_info.displayed_password_field_on_http);
   EXPECT_EQ(SecurityStateModel::HTTP_SHOW_WARNING,
             security_info.security_level);
 }
 
 // Tests that credit card fields cause the security level to be downgraded
 // to HTTP_SHOW_WARNING when the command-line switch is set.
 TEST(SecurityStateModelTest, CreditCardFieldWarning) {
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kMarkHttpAs,
       switches::kMarkHttpWithPasswordsOrCcWithChip);
   TestSecurityStateModelClient client;
   client.UseHttpUrl();
   SecurityStateModel model;
   model.SetClient(&client);
   client.set_displayed_credit_card_field_on_http(true);
   SecurityStateModel::SecurityInfo security_info;
   model.GetSecurityInfo(&security_info);
-  EXPECT_TRUE(security_info.displayed_private_user_data_input_on_http);
+  EXPECT_TRUE(security_info.displayed_credit_card_field_on_http);
   EXPECT_EQ(SecurityStateModel::HTTP_SHOW_WARNING,
             security_info.security_level);
 }
 
 // Tests that neither password nor credit fields cause the security
 // level to be downgraded to HTTP_SHOW_WARNING when the command-line switch
 // is NOT set.
 TEST(SecurityStateModelTest, HttpWarningNotSetWithoutSwitch) {
   TestSecurityStateModelClient client;
   client.UseHttpUrl();
   SecurityStateModel model;
   model.SetClient(&client);
   client.set_displayed_password_field_on_http(true);
-  client.set_displayed_credit_card_field_on_http(true);
   SecurityStateModel::SecurityInfo security_info;
   model.GetSecurityInfo(&security_info);
-  EXPECT_TRUE(security_info.displayed_private_user_data_input_on_http);
+  EXPECT_TRUE(security_info.displayed_password_field_on_http);
+  EXPECT_EQ(SecurityStateModel::NONE, security_info.security_level);
+
+  client.set_displayed_credit_card_field_on_http(true);
+  model.GetSecurityInfo(&security_info);
+  EXPECT_TRUE(security_info.displayed_credit_card_field_on_http);
   EXPECT_EQ(SecurityStateModel::NONE, security_info.security_level);
 }
 
-// Tests that |displayed_private_user_data_input_on_http| is not set
-// when the corresponding VisibleSecurityState flags are not set.
+// Tests that neither |displayed_password_field_on_http| nor
+// |displayed_credit_card_field_on_http| is set when the corresponding
+// VisibleSecurityState flags are not set.
 TEST(SecurityStateModelTest, PrivateUserDataNotSet) {
   TestSecurityStateModelClient client;
   client.UseHttpUrl();
   SecurityStateModel model;
   model.SetClient(&client);
   SecurityStateModel::SecurityInfo security_info;
   model.GetSecurityInfo(&security_info);
-  EXPECT_FALSE(security_info.displayed_private_user_data_input_on_http);
+  EXPECT_FALSE(security_info.displayed_password_field_on_http);
+  EXPECT_FALSE(security_info.displayed_credit_card_field_on_http);
   EXPECT_EQ(SecurityStateModel::NONE, security_info.security_level);
 }
 
 // Tests that SSL.MarkHttpAsStatus histogram is updated when security state is
 // computed for a page.
 TEST(SecurityStateModelTest, MarkHttpAsStatusHistogram) {
   const char* kHistogramName = "SSL.MarkHttpAsStatus";
   base::HistogramTester histograms;
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kMarkHttpAs, switches::kMarkHttpWithPasswordsOrCcWithChip);
@@ skipping 12 matching lines @@
 
   // Ensure histogram recorded correctly even without a password input.
   client.set_displayed_password_field_on_http(false);
   model.GetSecurityInfo(&security_info);
   histograms.ExpectUniqueSample(kHistogramName, 2 /* HTTP_SHOW_WARNING */, 2);
 }
 
 }  // namespace
 
 }  // namespace security_state