Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: components/security_state/security_state_model.cc

Issue 2483423002: HTTP Bad: Split out UMA metrics for password vs credit card "Not secure" warnings (Closed)
Patch Set: rebase to fix patch failure Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/security_state/security_state_model.h" 5 #include "components/security_state/security_state_model.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 visible_security_state.url.SchemeIsCryptographic(); 235 visible_security_state.url.SchemeIsCryptographic();
236 security_info->obsolete_ssl_status = 236 security_info->obsolete_ssl_status =
237 net::ObsoleteSSLStatus(security_info->connection_status); 237 net::ObsoleteSSLStatus(security_info->connection_status);
238 security_info->pkp_bypassed = visible_security_state.pkp_bypassed; 238 security_info->pkp_bypassed = visible_security_state.pkp_bypassed;
239 security_info->sct_verify_statuses = 239 security_info->sct_verify_statuses =
240 visible_security_state.sct_verify_statuses; 240 visible_security_state.sct_verify_statuses;
241 241
242 security_info->fails_malware_check = 242 security_info->fails_malware_check =
243 visible_security_state.fails_malware_check; 243 visible_security_state.fails_malware_check;
244 244
245 security_info->displayed_private_user_data_input_on_http = 245 security_info->displayed_password_field_on_http =
246 visible_security_state.displayed_password_field_on_http || 246 visible_security_state.displayed_password_field_on_http;
247 security_info->displayed_credit_card_field_on_http =
247 visible_security_state.displayed_credit_card_field_on_http; 248 visible_security_state.displayed_credit_card_field_on_http;
248 249
249 security_info->security_level = GetSecurityLevelForRequest( 250 security_info->security_level = GetSecurityLevelForRequest(
250 visible_security_state, client, security_info->sha1_deprecation_status, 251 visible_security_state, client, security_info->sha1_deprecation_status,
251 security_info->mixed_content_status, 252 security_info->mixed_content_status,
252 security_info->content_with_cert_errors_status); 253 security_info->content_with_cert_errors_status);
253 } 254 }
254 255
255 } // namespace 256 } // namespace
256 257
(...skipping 10 matching lines...) Expand all
267 sha1_deprecation_status(SecurityStateModel::NO_DEPRECATED_SHA1), 268 sha1_deprecation_status(SecurityStateModel::NO_DEPRECATED_SHA1),
268 mixed_content_status(SecurityStateModel::CONTENT_STATUS_NONE), 269 mixed_content_status(SecurityStateModel::CONTENT_STATUS_NONE),
269 content_with_cert_errors_status(SecurityStateModel::CONTENT_STATUS_NONE), 270 content_with_cert_errors_status(SecurityStateModel::CONTENT_STATUS_NONE),
270 scheme_is_cryptographic(false), 271 scheme_is_cryptographic(false),
271 cert_status(0), 272 cert_status(0),
272 security_bits(-1), 273 security_bits(-1),
273 connection_status(0), 274 connection_status(0),
274 key_exchange_group(0), 275 key_exchange_group(0),
275 obsolete_ssl_status(net::OBSOLETE_SSL_NONE), 276 obsolete_ssl_status(net::OBSOLETE_SSL_NONE),
276 pkp_bypassed(false), 277 pkp_bypassed(false),
277 displayed_private_user_data_input_on_http(false) {} 278 displayed_password_field_on_http(false),
279 displayed_credit_card_field_on_http(false) {}
278 280
279 SecurityStateModel::SecurityInfo::~SecurityInfo() {} 281 SecurityStateModel::SecurityInfo::~SecurityInfo() {}
280 282
281 SecurityStateModel::SecurityStateModel() {} 283 SecurityStateModel::SecurityStateModel() {}
282 284
283 SecurityStateModel::~SecurityStateModel() {} 285 SecurityStateModel::~SecurityStateModel() {}
284 286
285 void SecurityStateModel::GetSecurityInfo( 287 void SecurityStateModel::GetSecurityInfo(
286 SecurityStateModel::SecurityInfo* result) const { 288 SecurityStateModel::SecurityInfo* result) const {
287 VisibleSecurityState new_visible_state; 289 VisibleSecurityState new_visible_state;
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 other.displayed_content_with_cert_errors && 328 other.displayed_content_with_cert_errors &&
327 ran_content_with_cert_errors == other.ran_content_with_cert_errors && 329 ran_content_with_cert_errors == other.ran_content_with_cert_errors &&
328 pkp_bypassed == other.pkp_bypassed && 330 pkp_bypassed == other.pkp_bypassed &&
329 displayed_password_field_on_http == 331 displayed_password_field_on_http ==
330 other.displayed_password_field_on_http && 332 other.displayed_password_field_on_http &&
331 displayed_credit_card_field_on_http == 333 displayed_credit_card_field_on_http ==
332 other.displayed_credit_card_field_on_http); 334 other.displayed_credit_card_field_on_http);
333 } 335 }
334 336
335 } // namespace security_state 337 } // namespace security_state
OLDNEW
« no previous file with comments | « components/security_state/security_state_model.h ('k') | components/security_state/security_state_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698