chrome/browser/extensions/api/developer_private/developer_private_mangle.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/port_forwarding_browsertest.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc b/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

index a24a327b3c6d379288657c5aa5fcc60d75173a66..7ecb04a4c29ea3cf707722fc4d256cbeec51a889 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

@@ -104,7 +104,7 @@ api::developer_private::ItemInfo MangleExtensionInfo(

GURL url(view.url);

if (url.scheme() == kExtensionScheme) {

// No leading slash.

- view_copy.path = url.path().substr(1);

+ view_copy.path = url.path().substr(1).as_string();

} else {

// For live pages, use the full URL.

view_copy.path = url.spec();