chrome/browser/extensions/api/extension_action/browser_action_apitest.cc - Issue 2481923002: [WIP] make GURL::path() return a StringPiece

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)

Patch Set: thanks asan Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_mangle.cc ('k') | chrome/browser/extensions/api/extension_action/page_action_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

index 876abcc72a4f205de1a94ac1b907498804f73956..3ed530e588fec3f9ce5448d415ef8fe158578bf9 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

@@ -472,7 +472,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, BrowserActionAddPopup) {

<< "popup.";

ASSERT_STREQ("/a_popup.html",

- browser_action->GetPopupUrl(tab_id).path().c_str());

+ browser_action->GetPopupUrl(tab_id).path().as_string().c_str());

// Now change the popup from a_popup.html to another_popup.html by loading

// a page which removes the popup using chrome.browserAction.setPopup().

@@ -489,7 +489,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, BrowserActionAddPopup) {

ASSERT_TRUE(browser_action->HasPopup(tab_id));

ASSERT_TRUE(browser_action->HasPopup(ExtensionAction::kDefaultTabId));

ASSERT_STREQ("/another_popup.html",

- browser_action->GetPopupUrl(tab_id).path().c_str());

+ browser_action->GetPopupUrl(tab_id).path().as_string().c_str());

}

// Test that calling chrome.browserAction.setPopup() can remove a popup.