Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: chrome/browser/devtools/device/port_forwarding_browsertest.cc

Issue 2481923002: [WIP] make GURL::path() return a StringPiece (Closed)
Patch Set: thanks asan Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/port_forwarding_browsertest.cc
diff --git a/chrome/browser/devtools/device/port_forwarding_browsertest.cc b/chrome/browser/devtools/device/port_forwarding_browsertest.cc
index 475c52c1fb9d18dc25fa53661c3e5a2a4a00f6d0..cb6efa935a9bfe083fe9070d926fbf05fe92dfbd 100644
--- a/chrome/browser/devtools/device/port_forwarding_browsertest.cc
+++ b/chrome/browser/devtools/device/port_forwarding_browsertest.cc
@@ -92,8 +92,8 @@ IN_PROC_BROWSER_TEST_F(PortForwardingTest,
GURL original_url = embedded_test_server()->GetURL(kPortForwardingTestPage);
std::string forwarding_port("8000");
- GURL forwarding_url(original_url.scheme() + "://" +
- original_url.host() + ":" + forwarding_port + original_url.path());
+ GURL forwarding_url(original_url.scheme() + "://" + original_url.host() +
+ ":" + forwarding_port + original_url.path().as_string());
PrefService* prefs = profile->GetPrefs();
prefs->SetBoolean(prefs::kDevToolsPortForwardingEnabled, true);
@@ -163,8 +163,8 @@ IN_PROC_BROWSER_TEST_F(PortForwardingDisconnectTest, DisconnectOnRelease) {
GURL original_url = embedded_test_server()->GetURL(kPortForwardingTestPage);
std::string forwarding_port("8000");
- GURL forwarding_url(original_url.scheme() + "://" +
- original_url.host() + ":" + forwarding_port + original_url.path());
+ GURL forwarding_url(original_url.scheme() + "://" + original_url.host() +
+ ":" + forwarding_port + original_url.path().as_string());
PrefService* prefs = profile->GetPrefs();
prefs->SetBoolean(prefs::kDevToolsPortForwardingEnabled, true);

Powered by Google App Engine
This is Rietveld 408576698